Ensure BytesIter is an unsafe trait.

Closes #104. Part of fixes to addrss #100.
Alexhuszagh · Sep 9, 2024 · 113252e · 113252e
1 parent 24a1d6a
commit 113252e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lexical-util/src/iterator.rs b/lexical-util/src/iterator.rs
@@ -20,7 +20,7 @@ pub use crate::skip::{AsBytes, Bytes};
 /// A default implementation is provided for slice iterators.
 /// This trait **should never** return `null` from `as_ptr`, or be
 /// implemented for non-contiguous data.
-pub trait BytesIter<'a>: Iterator<Item = &'a u8> {
+pub unsafe trait BytesIter<'a>: Iterator<Item = &'a u8> {
     /// Determine if each yielded value is adjacent in memory.
     const IS_CONTIGUOUS: bool;
 

diff --git a/lexical-util/src/noskip.rs b/lexical-util/src/noskip.rs
@@ -232,7 +232,7 @@ pub struct BytesIterator<'a: 'b, 'b, const __: u128> {
     byte: &'b mut Bytes<'a, __>,
 }
 
-impl<'a: 'b, 'b, const __: u128> BytesIter<'a> for BytesIterator<'a, 'b, __> {
+unsafe impl<'a: 'b, 'b, const __: u128> BytesIter<'a> for BytesIterator<'a, 'b, __> {
     const IS_CONTIGUOUS: bool = Bytes::<'a, __>::IS_CONTIGUOUS;
 
     #[inline(always)]