ACS-3832: test support for parent queries against categories #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../tas-elasticsearch/src/test/java/org/alfresco/elasticsearch/reindexing/utils/Categories.java
Fixed
Show fixed
Hide fixed
tests/tas-elasticsearch/src/test/java/org/alfresco/elasticsearch/reindexing/utils/Category.java
Fixed
Show fixed
Hide fixed
Pawel-608
requested review from
krdabrowski,
mpichura,
azakrzewski-hy and
tpage-alfresco
| @@ -211,6 +219,8 @@ protected FileModel createDocument(String filename) | |||
| .createContent(new FileModel(filename, FileType.TEXT_PLAIN, "content")); | |||
| } | |||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Random extra new lines added 🚀
We should look into automatic formatting 🙂
| import org.springframework.stereotype.Component; | ||
|
|
||
| @Component | ||
| public class Categories |
There was a problem hiding this comment.
I think @krdabrowski added something similar for folders recently. If we're going to have more of these helper classes then we should think about the location of them. Perhaps it would be better to include them in com-repo since then they can be reused by all our E2E tests?
There was a problem hiding this comment.
I agree, we should move this stuff into comm-repo - we could do it in code review if there will be enough of time, or in tech debt week.
There was a problem hiding this comment.
I would move it there in tech debt week
Pawel-608
force-pushed
the
feature/ACS-3832-category-parent-query
branch
from
5373e08 to
f68b8da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.