Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment guide components and network checks #607

Merged
merged 7 commits into from
Jun 14, 2023

Conversation

morgan-patou
Copy link
Contributor

In relation to the previous PR #589, I split the doc & network checks related improvements/corrections in this new PR.

Included in this PR:

  • correction of the documentation and alignment between the doc and the network checks playbook that was available before but not doing all the checks
  • addition of some conditions for execution of tasks in the network checks playbook in case it's being executed on Community
  • Inclusion of the Alfresco Control Center on the documentation since I saw you pushed it recently into the master branch (c.f. OPSEXP-1645 Add Alfresco control center role #564)
  • Inclusion of the Alfresco Control Center on the network checks playbook

Not included in this PR:

  • Update of the docs/resources/*.png files. I believe that you generate the png files based on the puml. I suggested in this PR an update of the puml files, but I didn't re-generate the png, as I assume you have what is needed for that while I don't

Feel free to let me know if I need to update/remove something.

@gionn
Copy link
Member

gionn commented Jun 6, 2023

  • Update of the docs/resources/*.png files. I believe that you generate the png files based on the puml. I suggested in this PR an update of the puml files, but I didn't re-generate the png, as I assume you have what is needed for that while I don't

I've kickstarted #611 to tackle that in an automated fashion, you can rebase if merged soon or we will take care of that later 👍🏻

@gionn gionn requested review from alxgomz and gionn June 6, 2023 09:06
gionn
gionn previously approved these changes Jun 6, 2023
Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gionn
Copy link
Member

gionn commented Jun 6, 2023

Fix for this failing e2e is already in master

  TASK [Compare host OS with supported matrix] ***********************************
  fatal: [search-enteprise-integration-instance]: FAILED! => {"changed": false, "msg": ["Rocky 8.8 is not a supported OS"]}

@gionn gionn self-assigned this Jun 6, 2023
Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight change

Comment on lines +124 to +125
roles:
- role: '../roles/helper_modules'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you calling the role if you include the tasks explicitly?
To be fair, that stuff should not even be a role. If you feel like moving it to the playbook level feel free to do so.
If not, then just remove the roles execution

Copy link
Contributor Author

@morgan-patou morgan-patou Jun 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the other play of this playbook do that, I simply duplicated the ADW play and changed all adw references with acc, since that seems to be what was required for ACC as well. Isn't that to load the library listen_port.py that is then used inside the check_port.yml task? If that isn't the reason, I do not know, you did it like that for other plays so I just did the same.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh lord yes you're most likely right. That's a really ugly hack :-/
I've done some quick tests and it seems a single role is needed for the complete set of plays in this playbook to find the module file.
That said, I have created a new ticket to completely get rid of that roles: OPSEXP-2147 (shadows #438)
For now we can move forward with current code in this PR.

alxgomz
alxgomz previously approved these changes Jun 12, 2023
@alxgomz alxgomz force-pushed the doc-and-network-checks branch from ce084ac to f9a2d14 Compare June 12, 2023 07:45
@gionn gionn dismissed stale reviews from alxgomz and themself via 8a9a081 June 13, 2023 15:02
@gionn gionn force-pushed the doc-and-network-checks branch from be19337 to 69af5f4 Compare June 14, 2023 06:33
@gionn gionn changed the title Update doc and network checks Update deployment guide components and network checks Jun 14, 2023
@gionn gionn merged commit f22de29 into Alfresco:master Jun 14, 2023
morgan-patou added a commit to morgan-patou/alfresco-ansible-deployment that referenced this pull request Jun 19, 2023
Adding ACC port to fix conflict with master branch updated as part of PR Alfresco#607
@morgan-patou morgan-patou deleted the doc-and-network-checks branch November 15, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants