Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AAE-23145 Travis documentation removed #642

Merged
merged 6 commits into from
Jun 18, 2024
Merged

AAE-23145 Travis documentation removed #642

merged 6 commits into from
Jun 18, 2024

Conversation

wojciech-piotrowiak
Copy link
Contributor

Checklist

  • Jira Reference (also in PR title):
  • README updated after adding/changing behaviour of an action
  • Proposed version increment for release:
    • Patch (bugfix)
    • Minor (new feature)
    • Major (breaking changes)
  • External PR link where changes has been tested:

Description

Travis documentation removed

@wojciech-piotrowiak wojciech-piotrowiak requested a review from a team as a code owner June 13, 2024 07:17
gionn
gionn requested changes Jun 17, 2024
View reviewed changes
Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

env-load-from-yaml is still widely used because it's a good way to have versioned environment variables, you can drop just the travis reference in the docs.

the rest is good to drop

@wojciech-piotrowiak wojciech-piotrowiak force-pushed the feature/AAE-23145-travis-documentation-removed branch from e4b0838 to 3eb73bd Compare June 18, 2024 13:45
gionn
gionn reviewed Jun 18, 2024
View reviewed changes
version.txt Outdated Show resolved Hide resolved
@wojciech-piotrowiak wojciech-piotrowiak merged commit c58ea7c into master Jun 18, 2024
3 checks passed
@wojciech-piotrowiak wojciech-piotrowiak deleted the feature/AAE-23145-travis-documentation-removed branch June 18, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gionn gionn gionn approved these changes

@atchertchian atchertchian Awaiting requested review from atchertchian

@eromano eromano Awaiting requested review from eromano

@alxgomz alxgomz Awaiting requested review from alxgomz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wojciech-piotrowiak @gionn