Skip to content

Commit

Permalink
ACS-9023 Add override
Browse files Browse the repository at this point in the history
  • Loading branch information
damianujma committed Dec 4, 2024
1 parent 32f014d commit d46c76b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ public void setPreferenceService(PreferenceService preferenceService)
this.preferenceService = preferenceService;
}

@Override
public Preference getPreference(String personId, String preferenceName)
{
personId = people.validatePerson(personId);
Expand All @@ -76,12 +77,13 @@ public Preference getPreference(String personId, String preferenceName)
}
}

@Override
public CollectionWithPagingInfo<Preference> getPreferences(String personId, Paging paging)
{
personId = people.validatePerson(personId);

PagingResults<Pair<String, Serializable>> preferences = preferenceService.getPagedPreferences(personId, null, Util.getPagingRequest(paging));
List<Preference> ret = new ArrayList<Preference>(preferences.getPage().size());
List<Preference> ret = new ArrayList<>(preferences.getPage().size());
for (Pair<String, Serializable> prefEntity : preferences.getPage())
{
Preference pref = new Preference(prefEntity.getFirst(), prefEntity.getSecond());
Expand All @@ -91,6 +93,7 @@ public CollectionWithPagingInfo<Preference> getPreferences(String personId, Pagi
return CollectionWithPagingInfo.asPaged(paging, ret, preferences.hasMoreItems(), preferences.getTotalResultCount().getFirst());
}

@Override
public Preference updatePreference(String personId, Preference preference)
{
personId = people.validatePerson(personId, true);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public class ResourceWebScriptPut extends AbstractResourceWebScript implements P
RecognizedParamsExtractor, RequestReader
{

private static Log logger = LogFactory.getLog(ResourceWebScriptPut.class);
private static final Log logger = LogFactory.getLog(ResourceWebScriptPut.class);

Check warning

Code scanning / PMD

Logger should be defined private static final and have the correct class Warning

Logger should be defined private static final and have the correct class

Check warning

Code scanning / PMD

The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*' Warning

The constant name 'logger' doesn't match '[A-Z][A-Z_0-9]*'

public ResourceWebScriptPut()
{
Expand Down

0 comments on commit d46c76b

Please sign in to comment.