[MNT-24575] Added dialog to display folder information

[swapnil-verma-gl]

JIRA ticket link or changeset's description
https://hyland.atlassian.net/browse/MNT-24575

Added new dialog accessible via context menu to display folder information such as folder location, size, file count etc

[AleksanderSklorz]

@swapnil-verma-gl I'm getting some issue. When I'm opening dialog then many errors are inside console and dialog's look is broken:

[AleksanderSklorz]

@swapnil-verma-gl I see 2 issues, see video:

Screen.Recording.2024-12-19.at.12.51.55.mov

1. It says that there is 0 bytes but this folder has image inside so should have some bytes.
2. There is {{count}} placeholder instead of real number

NOTE: After some time, when you wait a bit, it seems working correctly.
NOTE2: Second issue happens also for folders with no files

[AleksanderSklorz]

@swapnil-verma-gl there is some accessibility issue:

[swapnil-verma-gl]

@swapnil-verma-gl there is some accessibility issue:

This issue is for the close button on the dialog, and seems to be related to the generic DialaogComponent (that folder information dialog is also using). It is also visible on the Manage Holds Dialog, which is also using the same Dialog component. I can fix it in this PR, but it would be in a completely separate file and not related to this feature. Should I do it, or raise a separate ticket for it?

[AleksanderSklorz]

@swapnil-verma-gl there is some accessibility issue:

This issue is for the close button on the dialog, and seems to be related to the generic DialaogComponent (that folder information dialog is also using). It is also visible on the Manage Holds Dialog, which is also using the same Dialog component. I can fix it in this PR, but it would be in a completely separate file and not related to this feature. Should I do it, or raise a separate ticket for it?

If that is small fix then it should be fine to fix it as part of this task. If this is bigger fix then you can create separate task. This fix probably won't be too big

[swapnil-verma-gl]

@swapnil-verma-gl I see 2 issues, see video:

Screen.Recording.2024-12-19.at.12.51.55.mov

1. It says that there is 0 bytes but this folder has image inside so should have some bytes.
2. There is {{count}} placeholder instead of real number

NOTE: After some time, when you wait a bit, it seems working correctly. NOTE2: Second issue happens also for folders with no files

It is possible that the size calculation does not happen properly for newly created files and folders (similar to how search does not seem to include newly uploaded files, until after their indexing is completed). I do remember their being some sort of discussion around the backend using indexes for efficiently calculating file sizes.

For empty folder, however, it does seem to be an issue. I am in discussion with the Backend team responsible for building the API around this, as the frontend doesn't really do any processing to the response other than mapping it to the UI elements.

The {{ count }} placeholder appearing is a bug, and I wlll fix that in an upcoming commit

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[swapnil-verma-gl]

@swapnil-verma-gl there is some accessibility issue:

This issue is for the close button on the dialog, and seems to be related to the generic DialaogComponent (that folder information dialog is also using). It is also visible on the Manage Holds Dialog, which is also using the same Dialog component. I can fix it in this PR, but it would be in a completely separate file and not related to this feature. Should I do it, or raise a separate ticket for it?

If that is small fix then it should be fine to fix it as part of this task. If this is bigger fix then you can create separate task. This fix probably won't be too big

Pushed the fix. It will appear in the ADF PR, since the DialogComponent is part of the ADF repo

[MichalKinas]

Shouldn't we use adf-icon for this?

[swapnil-verma-gl]

I tried to use adf-icon, but internally, its using mat-icons. Because of this, the only way for adf-icon to pickup custom svg icons from our assets folders, is by defining it in our app.extensions.json file. The other, more simpler option, if we have to use adf-icons, is to use mat-icons folder icon. However, using that would make this have a slight deviation from the figma design document. Do we want to go with

• Modified extensions.json to use the folder icon from assets folder
• Mat icons folder icon
• Leave this as-is

[MichalKinas]

Hmm to be honest I would start by asking the UX team if the material icon would be fine in this case, if they agree the issue is solved, if not I would go with custom icon and extensions.json modifications

[MichalKinas]

Can we make the error message a bit more specific depending on the error that BE returns us?

[MichalKinas]

And what about the error messages here?

[MichalKinas]

Same here