OPSEXP-2297: fixup & revert optional driverclass #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxgomz
changed the title
gionn
requested changes
Oct 31, 2023
alxgomz
force-pushed
the
OPSEXP-2297-fixup
branch
from
15983e1 to
496cf13
Compare
gionn
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: OPSEXP-2297
Making the DATABASE_DRIVER var optional didn't work unless url was set b values (reverted).
Siwtched the replacement of DATABASE_HOST & DATABASE_PORT from value templating to env variables within the pod (also didn't play well when param set using existingCm