Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added podannotations for search-services #160

Closed
wants to merge 1 commit into from

Conversation

shazada
Copy link
Contributor

@shazada shazada commented Dec 8, 2023

we use podAnnotations in the 'charts' so would like to have these in all chart, but for now atleast in search-services.

@alxgomz
Copy link
Contributor

alxgomz commented Dec 8, 2023

Hi @shazada,

In order to let the PR go through I would need to push a few more commits but I can't as your fork do not allow maintainers of upstream to push. Can you enable that? Otherwise I'll have to create another PR from a new branch I create.

Regards,

@shazada
Copy link
Contributor Author

shazada commented Dec 8, 2023

Thanks ik not shure how to give you rights is that a setting I can set somewhere?

@shazada
Copy link
Contributor Author

shazada commented Dec 8, 2023

I've just send you an invite so hopefully that works

@shazada shazada marked this pull request as draft December 8, 2023 18:42
@shazada shazada marked this pull request as ready for review December 8, 2023 18:43
@shazada
Copy link
Contributor Author

shazada commented Dec 8, 2023

Lol I can't seem to see the feature.
Screenshot_20231208_194342_Firefox

@alxgomz
Copy link
Contributor

alxgomz commented Dec 11, 2023

It should be present next to the "Comment" button in your PR:

image

Is it not?

@shazada
Copy link
Contributor Author

shazada commented Dec 11, 2023

image

@alxgomz
Copy link
Contributor

alxgomz commented Dec 12, 2023

After digging a bit it looks like we cannot contribute on PR whic are not coming from "user-owned" forks. I guess "Contezza" is a github org, so we'll have to create our own PR to add version bumps and tests.
Thanks for your contrib though!

@alxgomz
Copy link
Contributor

alxgomz commented Dec 12, 2023

superseeded by #161

@alxgomz alxgomz closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants