OPSEXP-2291 Bump Search services chart to most recent conventions #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gionn
force-pushed
the
OPSEXP-2291-refresh-solr
branch
3 times, most recently
from
83fcaf8 to
9bc425d
Compare
gionn
commented
Jan 5, 2024
charts/alfresco-search-service/templates/secret-repository.yaml
Outdated
Show resolved
Hide resolved
gionn
force-pushed
the
OPSEXP-2291-refresh-solr
branch
7 times, most recently
from
7a474da to
eecce1c
Compare
alxgomz
requested changes
Jan 9, 2024
| spec: | ||
| replicas: {{ .Values.replicaCount }} | ||
| selector: | ||
| matchLabels: | ||
| app: {{ template "alfresco-insight-zeppelin.fullName" . }} | ||
| release: {{ .Release.Name }} | ||
| {{- include "alfresco-insight-zeppelin.selectorLabels" . | nindent 6 }} | ||
| strategy: | ||
| type: RollingUpdate | ||
| rollingUpdate: {{- toYaml .Values.global.strategy.rollingUpdate | nindent 6 }} | ||
| template: | ||
| metadata: | ||
| annotations: | ||
| checksum/config: {{ include (print $.Template.BasePath "/config.yaml") . | sha256sum }} |
There was a problem hiding this comment.
why? we have a configmap and should help if changing it
There was a problem hiding this comment.
because it would lead to different behavior in case the user uses cm or values to configure the repo. Also this technic is more a workaround to me (e.g. a change in the metadata would also trigger pod recreation while not needed) and not a true feature. People should prefer solution such as reloader.
charts/alfresco-search-service/charts/alfresco-insight-zeppelin/templates/config.yaml
Show resolved
Hide resolved
charts/alfresco-search-service/templates/secret-repository.yaml
Outdated
Show resolved
Hide resolved
Apply automatic changes
Apply automatic changes
Apply automatic changes
gionn
force-pushed
the
OPSEXP-2291-refresh-solr
branch
from
b7a3419 to
180715b
Compare
gionn
force-pushed
the
OPSEXP-2291-refresh-solr
branch
from
bf28b61 to
603adaa
Compare
gionn
force-pushed
the
OPSEXP-2291-refresh-solr
branch
from
e076048 to
f145210
Compare
gionn
force-pushed
the
OPSEXP-2291-refresh-solr
branch
2 times, most recently
from
fb04888 to
353bd29
Compare
gionn
force-pushed
the
OPSEXP-2291-refresh-solr
branch
from
353bd29 to
883e04d
Compare
alxgomz
requested changes
Jan 11, 2024
| spec: | ||
| replicas: {{ .Values.replicaCount }} | ||
| selector: | ||
| matchLabels: | ||
| app: {{ template "alfresco-insight-zeppelin.fullName" . }} | ||
| release: {{ .Release.Name }} | ||
| {{- include "alfresco-insight-zeppelin.selectorLabels" . | nindent 6 }} | ||
| strategy: | ||
| type: RollingUpdate | ||
| rollingUpdate: {{- toYaml .Values.global.strategy.rollingUpdate | nindent 6 }} | ||
| template: | ||
| metadata: | ||
| annotations: | ||
| checksum/config: {{ include (print $.Template.BasePath "/config.yaml") . | sha256sum }} |
There was a problem hiding this comment.
because it would lead to different behavior in case the user uses cm or values to configure the repo. Also this technic is more a workaround to me (e.g. a change in the metadata would also trigger pod recreation while not needed) and not a true feature. People should prefer solution such as reloader.
alxgomz
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: OPSEXP-2291