Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSEXP-2444 Strict kubeconform from k8s 1.25 #182

Merged
merged 3 commits into from
Jan 17, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,18 +31,20 @@ repos:
name: "Kubeconform Helm - min k8s version"
files: ^charts/[^/]+/(\.kubeconform|\.helmignore|templates/NOTES.txt|.*\.(ya?ml|json|tpl))$
args:
- --kubernetes-version=1.21.0
- --exclude-charts=alfresco-common,alfresco-sync-service
- --kubernetes-version=1.25.0
- --exclude-charts=alfresco-common
- --values-dir=ci
- --strict
- repo: https://github.com/jtyr/kubeconform-helm
rev: v0.1.16
hooks:
- id: kubeconform-helm
name: "Kubeconform Helm - current k8s version"
files: ^charts/[^/]+/(\.kubeconform|\.helmignore|templates/NOTES.txt|.*\.(ya?ml|json|tpl))$
args:
- --exclude-charts=alfresco-common,alfresco-sync-service
- --exclude-charts=alfresco-common
- --values-dir=ci
- --strict
- repo: local
hooks:
- id: custom-check-chart-versions
Expand Down
13 changes: 13 additions & 0 deletions docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,19 @@ Each individual chart has its own documentation page that's available in the
chart directory in [charts/](../charts). There are the values available for
each of them.

## Testing

Each chart is tested against a default configuration on
[KinD](https://kind.sigs.k8s.io/). You can check the currently K8s version
tested by looking at the `KIND_NODE_IMAGE` value in the main [lint-test
workflow](../.github/workflows/lint-test.yaml).
gionn marked this conversation as resolved.
Show resolved Hide resolved

We are ensuring backward compatibility with older K8s versions with
[kubeconform](https://github.com/yannh/kubeconform). You can check the oldest
K8s version tested by looking at `kubernetes-version` inside the
`kubeconform-helm-min` hook in [pre-commit
configuration](../.pre-commit-config.yaml).

## Development

This repository follows the
Expand Down