-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: Add Guide for Configuring HotSwap Agent with Java 17 #681
base: master
Are you sure you want to change the base?
Conversation
9. Modify Tomcat `catalina.properties` file to add to the `shared.loader` the path `/usr/local/tomcat/hotswap-agent/sample-project-platform/target/classes` in order to allow the HotSwapAgent find the classes to reload in the `ParallelWebappClassLoader`. | ||
|
||
``` | ||
RUN sed -i '/^shared.loader=/ s|$|,${catalina.base}/hotswap-agent/sample-project-platform/target/classes|' catalina.properties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this contain the ${TOMCAT_DIR}/conf/catalina.properties
like this?:
RUN sed -i '/^shared.loader=/ s|$|,${catalina.base}/hotswap-agent/sample-project-platform/target/classes|' \
${TOMCAT_DIR}/conf/catalina.properties
Can you also share the Alfresco SDK version which you have used to test this procedure, please? I'm unable to make the HotSwap Agent work on the Alfresco SDK 4.10 due to the following error:
I think that this is caused by the line Before that, I had to change the line from step 9, since the ACS wouldn't start due to the missing path to
|
rm $TOMCAT_DIR/jbr_jcef-17.0.11-linux-x64-b1207.30.tar.gz && \ | ||
alternatives --install /usr/bin/java java /usr/lib/jvm/jbr_jcef-17.0.11-linux-x64-b1207.30/bin/java 40000 && \ | ||
alternatives --install /usr/bin/javac javac /usr/lib/jvm/jbr_jcef-17.0.11-linux-x64-b1207.30/bin/javac 40000 && \ | ||
alternatives --install /usr/bin/jar jar /usr/lib/jvm/jbr_jcef-17.0.11-linux-x64-b1207.30/bin/jar 40000 && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jbr_jcef-17.0.11-linux-x64-b1207.30
doesn't contain the bin/jar
file, but the developer binary jbrsdk_jcef-17.0.11-linux-x64-b1207.30.tar.gz does. Shouldn't we use that binary instead? Also, is the version with JCEF necessary? I think that the plain JBRSDK would suffice, since it already contains DCEVM.
Description
This PR adds comprehensive documentation to configure HotSwap Agent for Java 17 in the Alfresco SDK 4 context. The guide outlines the steps required to modify the default Alfresco Content Services (ACS) Docker image to support HotSwapAgent with Java 17, using a pre-built JetBrains Runtime OpenJDK.
Key Changes:
Documentation update
hotswap-agent.md
file with new instructions on configuring HotSwapAgent for Java 17.Dockerfile
modifications to install and configure the custom JDK for HotSwapAgent.docker-compose.yml