ATS-864: Switch from fabric8 to docker mvn plugin #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOutsSeeker
requested review from
KikoUK,
mpichura,
aymanthefirst and
PunchedChimera
KikoUK
approved these changes
Jul 8, 2021
pr-triage
bot
added
PR: partially-approved
PR: unreviewed
and removed
PR: unreviewed
PR: partially-approved
labels
|
It seems like you need docker-compose deployment for IT tests. |
PunchedChimera
requested changes
Jul 20, 2021
alfresco-transform-imagemagick/alfresco-transform-imagemagick-boot/pom.xml
Outdated
Show resolved
Hide resolved
alfresco-transform-core-aio/alfresco-transform-core-aio-boot/pom.xml
Outdated
Show resolved
Hide resolved
alfresco-transform-core-aio/alfresco-transform-core-aio-boot/pom.xml
Outdated
Show resolved
Hide resolved
…boot/pom.xml fix typo
mteodori
force-pushed
the
ATS-864_Switch_from_fabric8_to_docker_mvn_plugin
branch
from
d906f76 to
2f37037
Compare
|
If you merge this, please also create the A releases for code freeze (and 5 down stream projects) as they have been done already ACS-2573 |
PunchedChimera
approved these changes
Feb 22, 2022
|
Thanks @mteodori Some changes in line-endings only (so a little hard to see the PR diff in GitHub). See also ATS-690 ). As a workaround, use: https://github.com/Alfresco/alfresco-transform-core/pull/436/files?w=1 |
montgolfiere
approved these changes
Feb 22, 2022
mteodori
deleted the
ATS-864_Switch_from_fabric8_to_docker_mvn_plugin
branch
the changes are actually due to an existing mix of line endings in files, I've created another PR to fix and prevent this in the future using pre-commit as it's done in other repositories #540 |
montgolfiere
added a commit
that referenced
this pull request
Feb 25, 2022
* master: (52 commits) [maven-release-plugin][skip ci] prepare for next development iteration [maven-release-plugin][skip ci] prepare release 2.5.7-A4 ACS-2587 Fix test failure ACS-2587 Include directAccessUrl in T-Config if supported (#539) ATS-864: fix dependabot ATS-864: Switch from fabric8 to docker mvn plugin (#436) ACS-2072 Enforce third party license compliance. [maven-release-plugin][skip ci] prepare for next development iteration [maven-release-plugin][skip ci] prepare release 2.5.7-A3 [trigger release] 2.5.7-A3 Bump activemq-client from 5.16.3 to 5.16.4 (#534) Bump maven-javadoc-plugin from 3.3.1 to 3.3.2 (#533) ATS-981 Avoid CVE-2022-23181 with spring-boot-starter-web 2.6.3 (#537) [maven-release-plugin][skip ci] prepare for next development iteration [maven-release-plugin][skip ci] prepare release 2.5.7-A2 [trigger release] 2.5.7-A2 ACS-2497 Rework httpTransformRequestUsingDirectAccessUrlTest so it can be used in AI and Aspose (#535) Bump docker-maven-plugin from 0.38.1 to 0.39.0 (#528) [maven-release-plugin][skip ci] prepare for next development iteration [maven-release-plugin][skip ci] prepare release 2.5.7-A1 ... # Conflicts: # .travis.yml # alfresco-transformer-base/src/main/java/org/alfresco/transformer/util/RequestParamMap.java Also bumped pom.xml version (for two ffmpeg folders) from 2.5.5-A2-SNAPSHOT to match others (2.5.7-A5-SNAPSHOT)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced fabric8-maven-plugin with docker-maven-plugin and performed pom cleanup:
Ref. ATS-864