Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bool flag in open_operators! #249

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Use bool flag in open_operators! #249

merged 5 commits into from
Dec 11, 2024

Conversation

lukem12345
Copy link
Member

@lukem12345 lukem12345 commented Jun 18, 2024

This is a tiny PR that uses a bool in open_operators! instead of an index, just to be explicit. No behavior should change.

This might be a rare opportunity to use a fall-through switch statement, since all but one case returns true. But of course that's not completely necessary.

We have discovered that some open_operators tests were lost during the DiagrammaticEquations split, and those are now recovered in this PR.

@lukem12345 lukem12345 self-assigned this Jun 18, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.09%. Comparing base (10695ac) to head (d77ec31).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #249       +/-   ##
===========================================
+ Coverage   67.69%   78.09%   +10.40%     
===========================================
  Files           5        5               
  Lines         616      630       +14     
===========================================
+ Hits          417      492       +75     
+ Misses        199      138       -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GeorgeR227 GeorgeR227 merged commit b030b92 into main Dec 11, 2024
11 checks passed
@GeorgeR227 GeorgeR227 deleted the llm/bool-open branch December 11, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants