Generate Musical Isomorphisms by Default #269
Conversation
| @@ -5,6 +5,30 @@ using Krylov | |||
| using LinearAlgebra | |||
| using SparseArrays | |||
|
|
|||
| # Define mappings for default DEC operations that are not optimizable. | |||
There was a problem hiding this comment.
by optimizable do you mean able to be represented by a sparse matrix? The function below is called default_dec_matrix_generate, which has matrix in the name.
There was a problem hiding this comment.
No, for example, the sharp operator is a matrix, but we do not allocate memory for their outputs.
If I recall correctly, the generic term "optimizable" as used in this code base just means that the assignment uses either .= syntax or the mul! method when being emitted.
One of the things that I tried to do is amend this state of affairs, by drawing a distinction between operators with special logic that happen to be matrices, operators with special logic that do not happen to be matrices, and operators with no special logic and we do not care if they are matrices or not
| end | ||
|
|
||
| return (args...) -> op(args...) | ||
| end |
There was a problem hiding this comment.
I see that the function above is just a move of this + adding the sharp and flat.
GeorgeR227
force-pushed
the
llm/halfar-wedge
branch
from
74ad78b to
8cbca40
Compare
This reverts commit adbc661.
|
I'm realizing now that since this PR introduces the |
This moves operators over from the default matrix generate to the regular default generate to better define the split between operators that have inplace versions and those that don't.
Halmo is still breaking in this PR for some reason
This simulation was using A as a 1-form sized constant, instead of as a regular Float64 constant.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
==========================================
+ Coverage 78.09% 78.84% +0.75%
==========================================
Files 5 5
Lines 630 643 +13
==========================================
+ Hits 492 507 +15
+ Misses 138 136 -2 ☔ View full report in Codecov by Sentry. |
DiagrammaticEquations PR 67 added support for inferring variables as vector fields and resolving the musical isomorphism functions.
This PR updates our docs pages and internal simulation generation to accommodate this new feature.
A future PR should manage the pre-allocation of vectors of SVectors in an
autodiffcache-able way.@GeorgeR227 assisted in this feature.