Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export Stdlib #185

Closed
kris-brown opened this issue Jan 2, 2025 · 0 comments · Fixed by #187
Closed

Don't export Stdlib #185

kris-brown opened this issue Jan 2, 2025 · 0 comments · Fixed by #187

Comments

@kris-brown
Copy link
Collaborator

We've been reexporting Stdlib, which is great for things like easily using ThCategory in Catlab. However, there are a lot of things in Stdlib and they are likely to be more 'toy implementation' than the analogous thing we want in Catlab. For example, FinSetC is a great name for the category of finite sets and functions, but in Catlab it would be better to define this with the FinSet machinery that is defined there (the version in GATlab.Stdlib is a toy version of SkelFinSet). In general, there have been many name collisions (e.g. op) that seem harder to deal with than occasional explicit using GATlab.Stdlib: ThCategory, so I think it would be best to not reexport Stdlib.

For reference, here are all the names included in Stdlib:

BoolRing
DerivedModels
FinMatC
FinSetC
GATC
IntMonoid
IntNat
IntNatPlus
IntPreorder
IntPreorderCat
Maps
NatPlusMonoid
NothingC
OpC
OpCat
OpFinSetC
PreorderCat
SliceC
SliceOb
StdDerivedModels
StdModels
StdTheories
StdTheoryMaps
Stdlib
SwapMonoid
ThAb
ThAscCat
ThBooleanRing
ThCMonoid
ThCRig
ThCategory
ThClass
ThCommRModule
ThCommRing
ThDiffRing
ThDivisionRing
ThElementary
ThEmpty
ThGraph
ThGroup
ThLawlessCat
ThLawlessMonCat
ThLeftModule
ThMagma
ThModule
ThMonoid
ThNat
ThNatPlus
ThNatPlusTimes
ThPreorder
ThRightModule
ThRing
ThSemiGroup
ThSemiRing
ThSet
ThStrictMonCat
ThThinCategory
ZRing
op
@kris-brown kris-brown linked a pull request Jan 19, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant