Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reexport StdLib #187

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Don't reexport StdLib #187

merged 1 commit into from
Feb 7, 2025

Conversation

kris-brown
Copy link
Collaborator

GATlab standard library should be opt-in rather than exported by default, as it's often the case that important names (e.g. FinSetC, op) are claimed which might require alternative / more serious implementations elsewhere, such as Catlab.

@kris-brown kris-brown linked an issue Jan 19, 2025 that may be closed by this pull request
@kris-brown kris-brown changed the base branch from main to wrap January 19, 2025 18:22
@kris-brown kris-brown self-assigned this Feb 7, 2025
typecon too

allow subtyping in WithModel

Change how import works.

remove redundant Using Gatlab

.

.

fix docstrings

.
Migrate models with theorymap modules, not theorymaps
Don't reexport stdlib
@kris-brown kris-brown changed the base branch from wrap to main February 7, 2025 03:44
@kris-brown kris-brown merged commit 6c949c1 into main Feb 7, 2025
8 of 9 checks passed
@kris-brown kris-brown deleted the no_export branch February 7, 2025 03:46
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.92%. Comparing base (0fe4959) to head (dbea9db).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
- Coverage   95.09%   94.92%   -0.18%     
==========================================
  Files          38       38              
  Lines        2345     2345              
==========================================
- Hits         2230     2226       -4     
- Misses        115      119       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't export Stdlib
1 participant