Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit Dispatch model type and @default_model macro #177

Closed
wants to merge 10 commits into from

Conversation

kris-brown
Copy link
Collaborator

Addresses #176

@kris-brown kris-brown added the enhancement New feature or request label Dec 9, 2024
@kris-brown kris-brown self-assigned this Dec 9, 2024
@kris-brown kris-brown linked an issue Dec 9, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 85.58559% with 16 lines in your changes missing coverage. Please review.

Project coverage is 95.04%. Comparing base (a129cb4) to head (69dc438).

Files with missing lines Patch % Lines
src/models/ModelInterface.jl 82.14% 15 Missing ⚠️
src/syntax/gats/gat.jl 50.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (85.58%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@              Coverage Diff              @@
##           rem_model     #177      +/-   ##
=============================================
+ Coverage      93.85%   95.04%   +1.18%     
=============================================
  Files             38       38              
  Lines           2229     2299      +70     
=============================================
+ Hits            2092     2185      +93     
+ Misses           137      114      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kris-brown kris-brown mentioned this pull request Dec 9, 2024
@kris-brown kris-brown changed the base branch from main to not_implements December 9, 2024 21:52
@kris-brown kris-brown force-pushed the symbolic_model_explicit branch 3 times, most recently from 19d1841 to a7d785c Compare December 9, 2024 22:10
@kris-brown kris-brown force-pushed the symbolic_model_explicit branch from a7d785c to 69dc438 Compare December 12, 2024 01:46
Base automatically changed from not_implements to rem_model February 7, 2025 03:27
@kris-brown kris-brown deleted the branch rem_model February 7, 2025 03:28
@kris-brown kris-brown closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicit models which just use type dispatch
1 participant