Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate JunctionsTrees and Decompositions #25

Merged
merged 49 commits into from
Nov 20, 2024
Merged

Integrate JunctionsTrees and Decompositions #25

merged 49 commits into from
Nov 20, 2024

Conversation

samuelsonric
Copy link
Collaborator

@samuelsonric samuelsonric commented Nov 17, 2024

  • Refactored all of JunctionsTrees.
  • Added two constructors to Decompositions for creating a StrDecomp using graph elimination algorithms.

The two constructors have signatures

StrDecomp(
     graph::AbstractSymmetricGraph,
     ealg::Union{Order, EliminationAlgorithm}=DEFAULT_ELIMINATION_ALGORITHM,
     stype::SupernodeType=DEFAULT_SUPERNODE_TYPE)

StrDecomp(graph::AbstractSymmetricGraph, stree::SupernodeTree)

The type SupernodeTree encodes a supernodal elimination tree, an intermediate data structure used to construct a junction tree. It has a constructor

SupernodeTree(
     graph::AbstractSymmetricGraph,
     ealg::Union{Order, EliminationAlgorithm}=DEFAULT_ELIMINATION_ALGORITHM,
     stype::SupernodeType=DEFAULT_SUPERNODE_TYPE)

Supernodal elimination trees are cheaper to compute than full junction trees. Furthermore, they "know" the height and width of their corresponding junction trees. The following is a standard workflow in sparse matrix factorization.

  1. Compute several supernodal elimination trees using different elimination algorithms.
  2. Choose the tree with the smallest width to compute a junction tree.

Just updated the constructor to work on non-connected simple graphs by working on their connected components in parallel.

@samuelsonric samuelsonric marked this pull request as ready for review November 18, 2024 18:02
@samuelsonric samuelsonric marked this pull request as draft November 20, 2024 16:17
@samuelsonric samuelsonric marked this pull request as ready for review November 20, 2024 18:05
@samuelsonric samuelsonric merged commit 70c5f1f into main Nov 20, 2024
7 of 9 checks passed
@samuelsonric samuelsonric deleted the integrate branch November 20, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return JunctionTree as a StructuredDecomposition
1 participant