Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logger] Upgrade logger to support more options & Add constants module #91

Merged
merged 24 commits into from
Jan 20, 2025

Conversation

s5u13b
Copy link
Contributor

@s5u13b s5u13b commented Jan 13, 2025

  1. Upgrade logger to support more options such as log level, log prefix and custom logger. (adapted from vllm 0.6.6.post1).
  2. Add ray actor log prefix to show instance_id in each line of actor log and print job_id, worker_id, actor_id, node_id, instance_id during initialization. (useful for debug).
  3. Remove [function name] prefix from logger output text to make output text more standard.
  4. Add NodeFileHandler to support generating log files for each node (ray log files are for each actor).
  5. Add constants module to put all constants together.

@s5u13b s5u13b requested review from zhypku and KuilongCui January 13, 2025 12:15
Copy link

migration_size 1.59 GB 8.00 MB 16.00 MB 24.00 MB 32.00 MB 40.00 MB 48.00 MB 56.00 MB 64.00 MB 72.00 MB 80.00 MB 88.00 MB 96.00 MB 104.00 MB 112.00 MB 120.00 MB 128.00 MB 136.00 MB 144.00 MB 152.00 MB 160.00 MB 168.00 MB 176.00 MB 184.00 MB 192.00 MB 208.00 MB 224.00 MB 232.00 MB 240.00 MB 352.00 MB 584.00 MB
rayrpc_speed(GB/s) 3.88 1.02 1.47 1.77 1.91 2.05 2.09 2.13 2.21 2.26 2.28 2.34 2.34 2.44 2.40 2.46 2.43 2.40 2.50 2.53 2.58 2.49 2.48 2.71 2.62 2.46 2.88 2.75 2.79 3.00 3.27
migration_size 8.00 MB 16.00 MB 24.00 MB 32.00 MB 40.00 MB 48.00 MB 56.00 MB 64.00 MB 72.00 MB 80.00 MB 88.00 MB 96.00 MB 104.00 MB 112.00 MB 120.00 MB 128.00 MB 136.00 MB 144.00 MB 152.00 MB 160.00 MB 168.00 MB 176.00 MB 184.00 MB 200.00 MB 216.00 MB 232.00 MB 240.00 MB 336.00 MB 400.00 MB
gloo_speed(GB/s) 1.00 1.69 2.08 2.46 2.55 2.73 2.92 3.08 3.04 3.01 3.06 3.13 3.46 3.59 3.25 2.70 3.00 3.02 2.87 2.62 1.89 2.47 2.06 2.61 2.43 2.38 3.07 2.32 2.21

Copy link

prefill p25 p50 p75 p95 p99 mean
latency(ms) 12271.82 66131.05 127545.14 168051.00 191412.50 71622.77
decode p25 p50 p75 p95 p99 mean
latency(ms) 51.66 57.48 72.07 121.06 278.93 71.93

@s5u13b s5u13b changed the title [WIP][Logger] Upgrade logger to support more options [WIP][Logger] Upgrade logger to support more options & Add constants module Jan 14, 2025
Copy link

prefill p25 p50 p75 p95 p99 mean
latency(ms) 12817.01 71116.82 126767.38 200111.97 201920.85 77207.48
decode p25 p50 p75 p95 p99 mean
latency(ms) 49.56 54.11 63.18 113.96 261.57 64.17

@s5u13b s5u13b changed the title [WIP][Logger] Upgrade logger to support more options & Add constants module [Logger] Upgrade logger to support more options & Add constants module Jan 14, 2025
Copy link

migration_size 1.59 GB 8.00 MB 16.00 MB 24.00 MB 32.00 MB 40.00 MB 48.00 MB 56.00 MB 64.00 MB 72.00 MB 80.00 MB 88.00 MB 96.00 MB 104.00 MB 112.00 MB 120.00 MB 128.00 MB 136.00 MB 144.00 MB 152.00 MB 160.00 MB 168.00 MB 176.00 MB 184.00 MB 192.00 MB 200.00 MB 208.00 MB 224.00 MB 232.00 MB 256.00 MB 352.00 MB 568.00 MB 744.00 MB
rayrpc_speed(GB/s) 3.77 1.05 1.54 1.74 1.93 2.02 2.11 2.13 2.23 2.30 2.33 2.34 2.29 2.49 2.53 2.42 2.47 2.47 2.46 2.59 2.57 2.69 2.58 2.73 2.60 2.61 2.63 2.79 2.68 2.69 3.17 3.38 3.44
migration_size 8.00 MB 16.00 MB 24.00 MB 32.00 MB 40.00 MB 48.00 MB 56.00 MB 64.00 MB 72.00 MB 80.00 MB 88.00 MB 96.00 MB 104.00 MB 112.00 MB 120.00 MB 128.00 MB 136.00 MB 144.00 MB 152.00 MB 160.00 MB 168.00 MB 176.00 MB 184.00 MB 192.00 MB 200.00 MB 208.00 MB 216.00 MB 224.00 MB 232.00 MB 312.00 MB 336.00 MB 400.00 MB 576.00 MB
gloo_speed(GB/s) 1.03 1.64 2.11 2.44 2.62 2.76 2.85 2.87 3.00 2.97 2.65 2.92 3.10 3.67 3.27 3.13 3.05 2.86 2.48 2.66 2.25 3.18 2.06 0.71 3.07 2.38 2.96 2.66 2.82 2.40 0.89 0.45 1.41

Copy link

prefill p25 p50 p75 p95 p99 mean
latency(ms) 14089.30 74725.99 134143.80 168713.76 170931.38 76227.31
decode p25 p50 p75 p95 p99 mean
latency(ms) 50.31 55.34 66.14 112.58 328.65 69.01

Copy link

prefill p25 p50 p75 p95 p99 mean
latency(ms) 15572.92 82270.80 156729.08 176130.38 190413.57 84451.97
decode p25 p50 p75 p95 p99 mean
latency(ms) 48.46 52.35 58.01 88.73 129.02 58.10

Copy link

prefill p25 p50 p75 p95 p99 mean
latency(ms) 2871.33 68323.85 118705.86 174459.10 192919.60 70034.01
decode p25 p50 p75 p95 p99 mean
latency(ms) 51.80 57.14 69.17 106.02 268.59 66.29

Copy link

migration_size 8.00 MB 16.00 MB 24.00 MB 32.00 MB 40.00 MB 48.00 MB 56.00 MB 64.00 MB 72.00 MB 80.00 MB 88.00 MB 96.00 MB 104.00 MB 112.00 MB 120.00 MB 128.00 MB 136.00 MB 144.00 MB 152.00 MB 160.00 MB 168.00 MB 176.00 MB 184.00 MB 192.00 MB 200.00 MB 216.00 MB 224.00 MB 232.00 MB 240.00 MB 256.00 MB 280.00 MB 424.00 MB
rayrpc_speed(GB/s) 1.03 1.48 1.73 1.88 2.00 2.06 2.07 2.18 2.21 2.21 2.27 2.32 2.31 2.30 2.26 2.42 2.39 2.51 2.49 2.34 2.40 2.53 2.44 2.42 2.31 2.44 2.54 2.46 2.59 2.66 2.78 3.13
migration_size 8.00 MB 16.00 MB 24.00 MB 32.00 MB 40.00 MB 48.00 MB 56.00 MB 64.00 MB 72.00 MB 80.00 MB 88.00 MB 96.00 MB 104.00 MB 112.00 MB 120.00 MB 128.00 MB 136.00 MB 144.00 MB 152.00 MB 160.00 MB 168.00 MB 176.00 MB 184.00 MB 200.00 MB 224.00 MB 248.00 MB 304.00 MB
gloo_speed(GB/s) 1.03 1.68 2.10 2.39 2.49 2.76 2.73 2.96 3.10 3.09 3.13 3.35 3.24 3.09 2.64 2.63 2.86 2.75 2.76 2.89 2.16 3.13 1.92 2.77 3.20 3.02 3.42

Copy link

prefill p25 p50 p75 p95 p99 mean
latency(ms) 16854.48 87736.15 128762.88 181909.83 182804.94 78848.50
decode p25 p50 p75 p95 p99 mean
latency(ms) 50.43 54.17 61.84 97.95 271.56 64.15

Copy link

migration_size 8.00 MB 16.00 MB 24.00 MB 32.00 MB 40.00 MB 48.00 MB 56.00 MB 64.00 MB 72.00 MB 80.00 MB 88.00 MB 96.00 MB 104.00 MB 112.00 MB 120.00 MB 128.00 MB 136.00 MB 144.00 MB 152.00 MB 160.00 MB 168.00 MB 176.00 MB 184.00 MB 192.00 MB 200.00 MB 208.00 MB 216.00 MB 224.00 MB 232.00 MB 280.00 MB 336.00 MB 360.00 MB 384.00 MB 544.00 MB
rayrpc_speed(GB/s) 1.04 1.55 1.82 1.95 2.09 2.14 2.15 2.22 2.30 2.28 2.36 2.35 2.42 2.40 2.44 2.46 2.52 2.42 2.50 2.50 2.53 2.60 2.45 2.57 2.56 2.52 2.41 2.85 2.70 2.75 2.84 3.03 3.10 3.22
migration_size 8.00 MB 16.00 MB 24.00 MB 32.00 MB 40.00 MB 48.00 MB 56.00 MB 64.00 MB 72.00 MB 80.00 MB 88.00 MB 96.00 MB 104.00 MB 112.00 MB 120.00 MB 128.00 MB 136.00 MB 144.00 MB 152.00 MB 160.00 MB 168.00 MB 176.00 MB 184.00 MB 192.00 MB 200.00 MB 216.00 MB 224.00 MB 232.00 MB 240.00 MB 312.00 MB 560.00 MB
gloo_speed(GB/s) 1.01 1.67 2.09 2.40 2.51 2.82 2.93 2.87 3.15 3.08 3.04 3.19 3.26 3.16 3.32 2.55 2.64 2.61 2.91 2.89 2.26 2.42 3.50 2.63 2.72 3.33 3.22 3.42 1.89 1.87 1.90

llumnix/manager.py Outdated Show resolved Hide resolved
llumnix/manager.py Outdated Show resolved Hide resolved
llumnix/manager.py Outdated Show resolved Hide resolved
llumnix/manager.py Outdated Show resolved Hide resolved
llumnix/global_scheduler/global_scheduler.py Outdated Show resolved Hide resolved
llumnix/backends/vllm/worker.py Outdated Show resolved Hide resolved
llumnix/backends/vllm/worker.py Outdated Show resolved Hide resolved
llumnix/backends/bladellm/llm_engine.py Outdated Show resolved Hide resolved
@s5u13b s5u13b requested a review from ZeldaHuang January 17, 2025 06:56
Copy link

migration_size 8.00 MB 16.00 MB 24.00 MB 32.00 MB 40.00 MB 48.00 MB 56.00 MB 64.00 MB 72.00 MB 80.00 MB 88.00 MB 96.00 MB 104.00 MB 112.00 MB 120.00 MB 128.00 MB 136.00 MB 144.00 MB 152.00 MB 160.00 MB 168.00 MB 176.00 MB 184.00 MB 192.00 MB 200.00 MB 208.00 MB 216.00 MB 224.00 MB 256.00 MB 360.00 MB 456.00 MB 480.00 MB
rayrpc_speed(GB/s) 1.04 1.50 1.75 1.91 2.00 2.03 2.10 2.14 2.26 2.30 2.32 2.29 2.41 2.47 2.43 2.43 2.53 2.57 2.47 2.54 2.61 2.53 2.60 2.55 2.58 2.57 2.49 2.56 2.79 3.05 3.04 3.26
migration_size 8.00 MB 16.00 MB 24.00 MB 32.00 MB 40.00 MB 48.00 MB 56.00 MB 64.00 MB 72.00 MB 80.00 MB 88.00 MB 96.00 MB 104.00 MB 112.00 MB 120.00 MB 128.00 MB 136.00 MB 144.00 MB 152.00 MB 160.00 MB 176.00 MB 184.00 MB 200.00 MB 216.00 MB 224.00 MB 232.00 MB 352.00 MB
gloo_speed(GB/s) 1.03 1.70 2.14 2.42 2.63 2.74 2.96 3.07 2.99 3.11 3.22 3.32 3.35 3.45 3.61 2.93 2.40 3.12 2.29 2.65 3.72 1.68 2.51 1.54 2.91 2.15 1.11

Copy link

prefill p25 p50 p75 p95 p99 mean
latency(ms) 12461.40 83662.32 131383.31 168173.68 168637.83 77951.35
decode p25 p50 p75 p95 p99 mean
latency(ms) 51.16 54.52 63.04 98.94 143.78 62.06

Copy link

migration_size 1.59 GB 8.00 MB 16.00 MB 24.00 MB 32.00 MB 40.00 MB 48.00 MB 56.00 MB 64.00 MB 72.00 MB 80.00 MB 88.00 MB 96.00 MB 104.00 MB 112.00 MB 120.00 MB 128.00 MB 136.00 MB 144.00 MB 152.00 MB 160.00 MB 168.00 MB 176.00 MB 184.00 MB 192.00 MB 200.00 MB 224.00 MB 240.00 MB 280.00 MB 336.00 MB 352.00 MB 568.00 MB
rayrpc_speed(GB/s) 4.00 1.06 1.55 1.80 1.94 2.08 2.09 2.10 2.22 2.26 2.30 2.36 2.40 2.36 2.45 2.44 2.48 2.42 2.54 2.63 2.53 2.63 2.60 2.58 2.62 2.61 2.73 2.73 2.95 3.10 3.19 3.48
migration_size 8.00 MB 16.00 MB 24.00 MB 32.00 MB 40.00 MB 48.00 MB 56.00 MB 64.00 MB 72.00 MB 80.00 MB 88.00 MB 96.00 MB 104.00 MB 112.00 MB 120.00 MB 128.00 MB 136.00 MB 144.00 MB 152.00 MB 160.00 MB 168.00 MB 176.00 MB 184.00 MB 192.00 MB 200.00 MB 216.00 MB 224.00 MB 256.00 MB 320.00 MB 344.00 MB
gloo_speed(GB/s) 1.01 1.64 2.06 2.36 2.44 2.77 2.75 2.98 3.05 3.01 3.00 3.14 3.28 2.99 3.12 2.81 3.02 2.63 2.72 2.98 2.35 2.73 2.93 2.28 3.53 2.23 2.72 2.92 2.26 4.32

Copy link

prefill p25 p50 p75 p95 p99 mean
latency(ms) 19417.60 85168.86 135161.67 171970.80 180215.48 81585.69
decode p25 p50 p75 p95 p99 mean
latency(ms) 50.03 53.71 62.14 93.51 165.56 63.09

@s5u13b s5u13b merged commit f12d6c3 into main Jan 20, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants