-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logger] Upgrade logger to support more options & Add constants module #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
s5u13b
commented
Jan 13, 2025
•
edited
Loading
edited
- Upgrade logger to support more options such as log level, log prefix and custom logger. (adapted from vllm 0.6.6.post1).
- Add ray actor log prefix to show instance_id in each line of actor log and print job_id, worker_id, actor_id, node_id, instance_id during initialization. (useful for debug).
- Remove [function name] prefix from logger output text to make output text more standard.
- Add NodeFileHandler to support generating log files for each node (ray log files are for each actor).
- Add constants module to put all constants together.
|
|
s5u13b
changed the title
[WIP][Logger] Upgrade logger to support more options
[WIP][Logger] Upgrade logger to support more options & Add constants module
Jan 14, 2025
|
s5u13b
changed the title
[WIP][Logger] Upgrade logger to support more options & Add constants module
[Logger] Upgrade logger to support more options & Add constants module
Jan 14, 2025
|
|
|
|
|
|
|
KuilongCui
approved these changes
Jan 16, 2025
|
|
|
|
zhypku
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.