-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swenzel/refactormacrotests #320
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* based on a macro extracted from ROOTMacros.cmake * modified to our needs (more configurability) * do no longer depend on the config coming from FairRoot which makes assumptions on variables not relevant for O2
* refactoring of unit test generation from ROOT macros (using new mechanism) * selectively enable unit tests based on G3/G4 availability * NOTE: for the moment some tests have been commented out, they will gradually reappear when they are fixed
Error while checking build/o2checkcode/o2-daq for 5ed1a5f:
Full log here. |
@sawenzel is this still relevant or should we close it? |
I believe this is still relevant in order to get the simulations running as unit test. Will open a new PR when I find some time for it. |
knopers8
pushed a commit
to knopers8/AliceO2
that referenced
this pull request
Sep 7, 2020
* [EMCAL-527] Adding RawCheck Implemented Checks: - checker for ErrorType histogram * Remove extra empty line. * trigger build Co-authored-by: Giulio Eulisse <[email protected]> Co-authored-by: Barthélémy von Haller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #299. These commits help making the unit tests run again correctly.
Do not merge yet ... just for testing.