changed variable names to be more descriptive and remove redundant check

AliceO2Group · Dec 9, 2024 · 28ff5b2 · 28ff5b2
1 parent efbfe5f
commit 28ff5b2
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/lib/usecases/run/GetAllRunsUseCase.js b/lib/usecases/run/GetAllRunsUseCase.js
@@ -77,34 +77,34 @@ class GetAllRunsUseCase {
             } = filter;
 
             if (runNumbers) {
-                const runNumberList = runNumbers.split(SEARCH_ITEMS_SEPARATOR)
-                    .map((runNumber) => runNumber.trim())
+                const runNumberCriteria = runNumbers.split(SEARCH_ITEMS_SEPARATOR)
+                    .map((runNumbers) => runNumbers.trim())
                     .filter(Boolean);
 
-                const allRuns = new Set();
+                const runNumberSet = new Set();
 
-                runNumberList.forEach((runNumber) => {
+                runNumberCriteria.forEach((runNumber) => {
                     if (runNumber.includes('-')) {
                         const [start, end] = runNumber.split('-').map((n) => parseInt(n, 10));
-                        if (!Number.isNaN(start) && !Number.isNaN(end) && start <= end) {
+                        if (!Number.isNaN(start) && !Number.isNaN(end)) {
                             for (let i = start; i <= end; i++) {
-                                allRuns.add(i);
+                                runNumberSet.add(i);
                             }
                         }
                     } else {
                         const parsedRunNumber = parseInt(runNumber, 10);
                         if (!Number.isNaN(parsedRunNumber)) {
-                            allRuns.add(parsedRunNumber);
+                            runNumberSet.add(parsedRunNumber);
                         }
                     }
                 });
 
-                const finalRunList = Array.from(allRuns);
-                if (finalRunList.length) {
-                    if (finalRunList.length > 1) {
-                        filteringQueryBuilder.where('runNumber').oneOf(...finalRunList);
+                const finalRunNumberList = Array.from(runNumberSet);
+                if (finalRunNumberList.length) {
+                    if (finalRunNumberList.length > 1) {
+                        filteringQueryBuilder.where('runNumber').oneOf(...finalRunNumberList);
                     } else {
-                        const [runNumber] = finalRunList;
+                        const [runNumber] = finalRunNumberList;
                         filteringQueryBuilder.where('runNumber').substring(`${runNumber}`);
                     }
                 }