[O2B-844] Filter according to B field in runs #1803
+78
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1803 +/- ##
==========================================
- Coverage 43.77% 43.58% -0.19%
==========================================
Files 893 893
Lines 15959 15954 -5
Branches 3005 3003 -2
==========================================
- Hits 6986 6954 -32
- Misses 8973 9000 +27 ☔ View full report in Codecov by Sentry. |
martinboulais
requested changes
Dec 2, 2024
martinboulais
requested changes
Dec 2, 2024
test/public/runs/overview.test.js
Outdated
| @@ -596,6 +596,21 @@ module.exports = () => { | |||
| expect(runDurationList.every((runDuration) => runDuration === 'UNKNOWN')).to.be.true; | |||
| }); | |||
|
|
|||
| it('should successfully apply alice currents filters', async () => { | |||
| await goToPage(page, 'run-overview'); | |||
There was a problem hiding this comment.
You should avoid as much as possible to use goToPage, at some point it make pupeteer crash (I was not able to figure out why). Please try to pressElement on the runs overview link at the top of the page for example.
martinboulais
requested changes
Dec 4, 2024
| @@ -306,7 +306,7 @@ module.exports = () => { | |||
| it('should successfully filter on detectors', async () => { | |||
| // Open filter toggle | |||
| await pressElement(page, '#openFilterToggle'); | |||
| await page.waitForSelector('.detectors-filter .dropdown-trigger'); | |||
| await page.waitForSelector('.detectors-filter .dropdown-trigger', { visible: true }); | |||
There was a problem hiding this comment.
Why this change? Same for all the {visible: true}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
-tag colours will now update when looking at run details
Notable changes for developers:
Changes made to the database: