Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O2B-532] Create a reusable filtering system #832

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

[O2B-532] Create a reusable filtering system #832

wants to merge 10 commits into from

Conversation

martinboulais
Copy link
Collaborator

@martinboulais martinboulais commented Dec 13, 2022 •
edited
Loading

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for developers:

  • A simplified and reusable frontend filtering system has been set-up

@martinboulais martinboulais changed the title Feature/o2 b 532/factorize filtering [O2B-532] Create a reusable filtering system Dec 13, 2022
@martinboulais martinboulais force-pushed the feature/O2B-532/factorize-filtering branch 3 times, most recently from a5b2181 to 9a9e448 Compare December 13, 2022 14:49
@martinboulais martinboulais self-assigned this Dec 15, 2022
@martinboulais martinboulais force-pushed the feature/O2B-532/factorize-filtering branch 2 times, most recently from 80d6648 to a65c4fe Compare January 19, 2023 14:43
@martinboulais martinboulais force-pushed the feature/O2B-532/factorize-filtering branch from a65c4fe to ef44cca Compare February 2, 2023 14:01
@martinboulais martinboulais force-pushed the feature/O2B-532/factorize-filtering branch 2 times, most recently from c32ba36 to a7fad30 Compare March 1, 2023 10:55
@martinboulais martinboulais force-pushed the feature/O2B-532/factorize-filtering branch 3 times, most recently from 9119426 to 06b9a15 Compare April 25, 2023 08:59
@martinboulais martinboulais force-pushed the feature/O2B-532/factorize-filtering branch from 06b9a15 to aa4f561 Compare November 29, 2023 13:48
@martinboulais martinboulais force-pushed the feature/O2B-532/factorize-filtering branch 2 times, most recently from 858366b to 4c9d62b Compare January 23, 2024 11:08
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 103 lines in your changes missing coverage. Please review.

Project coverage is 43.77%. Comparing base (f665ae4) to head (663b33b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...nents/common/form/inputs/DateTimeInputComponent.js 0.00% 32 Missing ⚠️
...public/components/Filters/common/FilteringModel.js 0.00% 28 Missing ⚠️
...ib/public/views/Runs/Overview/RunsOverviewModel.js 0.00% 27 Missing ⚠️
...public/components/Filters/common/TagFilterModel.js 0.00% 7 Missing ⚠️
...ib/public/views/Logs/Overview/LogsOverviewModel.js 0.00% 2 Missing ⚠️
...lic/components/Filters/RunsFilter/o2StartFilter.js 0.00% 1 Missing ⚠️
...blic/components/Filters/RunsFilter/o2StopFilter.js 0.00% 1 Missing ⚠️
...ents/Filters/common/filters/TimeRangeInputModel.js 0.00% 1 Missing ⚠️
...components/common/chart/rendering/ChartRenderer.js 0.00% 1 Missing ⚠️
...omponents/common/form/inputs/DateTimeInputModel.js 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
- Coverage   43.78%   43.77%   -0.01%     
==========================================
  Files         893      893              
  Lines       15954    15886      -68     
  Branches     3003     2976      -27     
==========================================
- Hits         6985     6954      -31     
+ Misses       8969     8932      -37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinboulais martinboulais force-pushed the feature/O2B-532/factorize-filtering branch 2 times, most recently from 8fe30d8 to 6bd7741 Compare March 28, 2024 18:15
@martinboulais martinboulais force-pushed the feature/O2B-532/factorize-filtering branch 2 times, most recently from 85b3be4 to 0ab6ff5 Compare April 22, 2024 06:31
@martinboulais martinboulais force-pushed the feature/O2B-532/factorize-filtering branch from 0ab6ff5 to c6e2d5b Compare November 26, 2024 10:44
@martinboulais martinboulais force-pushed the feature/O2B-532/factorize-filtering branch 4 times, most recently from 4fefe66 to b4af8fa Compare December 11, 2024 15:01
@martinboulais martinboulais force-pushed the feature/O2B-532/factorize-filtering branch from b4af8fa to 663b33b Compare December 11, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graduta graduta Awaiting requested review from graduta graduta will be requested when the pull request is marked ready for review graduta is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@martinboulais martinboulais

Labels
frontend
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@martinboulais