Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable parallel world in anchored simulation #1786

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

enable parallel world in anchored simulation #1786

wants to merge 3 commits into from

Conversation

maciacco
Copy link

@maciacco maciacco commented Nov 5, 2024

@mconcas @sawenzel I added the parallel world configurables in the python and bash scripts for the anchored workflow creation. I also added a variable in the pp test script to enable the parallel geometry navigation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

sawenzel
sawenzel reviewed Nov 8, 2024
View reviewed changes
MC/bin/o2dpg_sim_workflow_anchored.py Outdated
@@ -312,6 +312,7 @@ def main():
parser.add_argument("-tf", type=int, help="number of timeframes per job", default=1)
parser.add_argument("--ccdb-IRate", type=bool, help="whether to try fetching IRate from CCDB/CTP", default=True)
parser.add_argument("--trig-eff", type=float, dest="trig_eff", help="Trigger eff needed for IR", default=-1.0)
parser.add_argument("-enable-parallel-world", type=int, dest="enable_parallel_world", help="Enable parallel geometry", default=0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be needed. We can already pass simulation config key values from the outside.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review, I removed this in the latest commit

sawenzel
sawenzel requested changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@sawenzel sawenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle, we can pass config key values from the outside using the -confKey of o2dpg_sim_workflow.py;

Before doing bigger changes such as in this PR, could you please check if this works or what are the show-stoppers with such approach?

@maciacco
Copy link
Author

@sawenzel thanks for your comment, I modified the implementation by forwarding the parallel world configuration to o2dpg_sim_workflow.py as you suggested. This gives the same results as before in the workflow creation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sawenzel sawenzel sawenzel requested changes

@chiarazampolli chiarazampolli Awaiting requested review from chiarazampolli chiarazampolli is a code owner

@benedikt-voelkel benedikt-voelkel Awaiting requested review from benedikt-voelkel benedikt-voelkel is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciacco @sawenzel