Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITS tracking: update PbPb params for apass1 #1827

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

mconcas
Copy link
Collaborator

@mconcas mconcas commented Dec 3, 2024

@chiarazampolli : as discussed, I also added the label for apass4 of PbPb 2023 let me know if this does require more work.

Copy link

github-actions bot commented Dec 3, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@mconcas
Copy link
Collaborator Author

mconcas commented Dec 3, 2024

+async-label async-2024-PbPb-apass1, async-2023-pbpb-apass4

@github-actions github-actions bot added async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 async-2024-pp-apass1 Request porting to async-2024-pp-apass1 labels Dec 3, 2024
@chiarazampolli chiarazampolli removed the async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 label Dec 3, 2024
@github-actions github-actions bot added async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 async-2024-PbPb-apass1 labels Dec 3, 2024
@chiarazampolli
Copy link
Collaborator

Ciao @mconcas ,

I think there was a misunderstanding: we should not port this to the PbPb 23 apass4 tag, actually, or it will spoil the MCs anchored to it. So I removed it. This will be taken for any future apass5 of PbPb 23.

Chiara

@mconcas mconcas removed async-2024-pp-apass1 Request porting to async-2024-pp-apass1 async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 labels Dec 3, 2024
@AliceO2Group AliceO2Group deleted a comment from github-actions bot Dec 3, 2024
@AliceO2Group AliceO2Group deleted a comment from github-actions bot Dec 3, 2024
@chiarazampolli
Copy link
Collaborator

Ciao @mconcas ,

There was another PR that I merged which touched the same file. Can you rebase to master? There seems to be no conflicts, but in the "files changed", I don't see the modifications from the other PR:

https://github.com/AliceO2Group/O2DPG/pull/1826/files

Do you know if it is normal? The same is true for https://github.com/AliceO2Group/O2DPG/pull/1828/files, @shahor02 . Maybe I am simply overcareful...

Chiara

@shahor02
Copy link
Collaborator

shahor02 commented Dec 3, 2024

Do you know if it is normal? The same is true for https://github.com/AliceO2Group/O2DPG/pull/1828/files, @shahor02 . Maybe I am simply overcareful...

@chiarazampolli this is because you merged your PR after I've opened mine. If my PR does not show the conflict with master, this means that the rebasing is not really necessary. But I've done it anyway.

@chiarazampolli chiarazampolli merged commit 6e7e34a into AliceO2Group:master Dec 3, 2024
6 of 8 checks passed
@chiarazampolli
Copy link
Collaborator

Merged, failures unrelated.

@chiarazampolli
Copy link
Collaborator

Hello @shahor02 ,

Thanks! Matteo did not do the rebase, and we now have the evidence that it works :-)

Thanks!

Chiara

@mconcas mconcas deleted the patch-2 branch December 3, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants