Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements files out of date: potentially hidden bugs #424

Closed
pgarrison opened this issue Sep 12, 2024 · 4 comments
Closed

Requirements files out of date: potentially hidden bugs #424

pgarrison opened this issue Sep 12, 2024 · 4 comments

Comments

@pgarrison
Copy link
Contributor

pgarrison commented Sep 12, 2024

Issue

The requirements.txt and pdm.lock files have not been updated in 5 months, but the pyproject.toml has had some revisions. The requirements.txt and pdm.lock files need to be kept up-to-date so that installation gives the expected dependency versions.

I noticed this issue because I tried to add support for python 3.11, so I needed to re-run Make Requirments to ensure the locked dependencies support python 3.11. But then I discovered that the tests for currently supported versions 3.9 and 3.10 failed, which suggests there are bigger issues than just the locked dependencies being outdated.

Potential solution

  • Run the Make Requirements action and merge the result, even if it causes tests to fail.
    • File new issues for test failures and work on them immediately
  • A github action should automatically update the requirements & lock files whenever pyproject.toml changes. This could be done by pushing commits to feature branches when PRs are created/edited, or creating a follow-up PR whenever a relevant PR is merged (see github.com/AllenCell/nuc-morph-analysis for an example)
@benjijamorris
Copy link
Contributor

Thanks again for digging through all this! My read is that it's BioIO error and the tests are failing either during image loading or during downstream tests for 3d because the image is a different shape than expected. I can start looking into what the Bioio change might have been, can you think of anyone else who might be able to help spot what package changes made this break?

@benjijamorris
Copy link
Contributor

The BioIo versions seem to match what's been working for me locally with python3.10.4 🤔

@pgarrison
Copy link
Contributor Author

Blocked by #427

@pgarrison
Copy link
Contributor Author

It seems there is already a github action to update the lock files, which maybe was just failing before. With #431 created and merged I think this is resolved. Though #433 still needs to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants