-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requirements files out of date: potentially hidden bugs #424
Comments
Thanks again for digging through all this! My read is that it's BioIO error and the tests are failing either during image loading or during downstream tests for 3d because the image is a different shape than expected. I can start looking into what the Bioio change might have been, can you think of anyone else who might be able to help spot what package changes made this break? |
The BioIo versions seem to match what's been working for me locally with python3.10.4 🤔 |
Blocked by #427 |
Issue
The
requirements.txt
andpdm.lock
files have not been updated in 5 months, but thepyproject.toml
has had some revisions. Therequirements.txt
andpdm.lock
files need to be kept up-to-date so that installation gives the expected dependency versions.I noticed this issue because I tried to add support for python 3.11, so I needed to re-run Make Requirments to ensure the locked dependencies support python 3.11. But then I discovered that the tests for currently supported versions 3.9 and 3.10 failed, which suggests there are bigger issues than just the locked dependencies being outdated.
Potential solution
pyproject.toml
changes. This could be done by pushing commits to feature branches when PRs are created/edited, or creating a follow-up PR whenever a relevant PR is merged (see github.com/AllenCell/nuc-morph-analysis for an example)The text was updated successfully, but these errors were encountered: