Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support python 3.11 #420

Closed
wants to merge 4 commits into from
Closed

Support python 3.11 #420

wants to merge 4 commits into from

Conversation

pgarrison
Copy link
Contributor

@pgarrison pgarrison commented Aug 29, 2024

Part of #419

Before submitting

  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

@pgarrison
Copy link
Contributor Author

Tests pass on ubuntu 3.11 but time out on windows, which is a pre-existing bug #422, so I think this PR is good to go?

benjijamorris
benjijamorris previously approved these changes Aug 29, 2024
@benjijamorris
Copy link
Contributor

Sweet! Thanks for doing this @pgarrison

@pgarrison pgarrison marked this pull request as draft August 30, 2024 00:04
@pgarrison
Copy link
Contributor Author

I realize that without updating test-requirements.txt, these tests are running against the old dependencies.

@pgarrison
Copy link
Contributor Author

Make requirements job seems to be failing confusingly

[KeyError]: 'Requires-Python'

@pgarrison
Copy link
Contributor Author

This change now broke the 3.9 and 3.10 builds. I notice that the requirements files haven't been updated in 5 months, so it's possible that there's a bigger problem lurking.

@pgarrison
Copy link
Contributor Author

Blocked by #424, closing for now

@pgarrison pgarrison closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants