Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/2d tests #307

Merged
merged 10 commits into from
Nov 3, 2023
Merged

Bugfix/2d tests #307

merged 10 commits into from
Nov 3, 2023

Conversation

benjijamorris
Copy link
Contributor

What does this PR do?

  • modify all models to work in 2d
  • modify configs so that all 3d->2d conversions can be done from experiment file
  • add tests for 2d models

on the a100s, all tests run in ~50 minutes, bumping up the timeout for github runners.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@ritvikvasan
Copy link
Member

test failed?

@benjijamorris
Copy link
Contributor Author

timed out, I'm not sure why python version / os changes the speed so much.

@benjijamorris benjijamorris merged commit 53d2c5d into main Nov 3, 2023
@benjijamorris benjijamorris deleted the bugfix/2d_tests branch November 3, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants