Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/lie learn windows #308

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Bugfix/lie learn windows #308

merged 3 commits into from
Nov 3, 2023

Conversation

benjijamorris
Copy link
Contributor

What does this PR do?

remove windows support for equiv so we can publish to pypi
update docs to reflect changes

Fixes #<issue_number>

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • [] Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@ritvikvasan
Copy link
Member

did you test that this installs fine?

@benjijamorris
Copy link
Contributor Author

yeah, looks like the installs for tests are fine

@benjijamorris benjijamorris merged commit 8555b8a into main Nov 3, 2023
5 of 8 checks passed
@benjijamorris benjijamorris deleted the bugfix/lie_learn_windows branch November 3, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants