Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/equiv padding weightedmse #346

Closed
wants to merge 3 commits into from

Conversation

ritvikvasan
Copy link
Member

@ritvikvasan ritvikvasan commented Mar 6, 2024

What does this PR do?

This PR adds a temporary fix to vae/image_encoder where Convolution class expects padding values to be tuple or int (cannot pass None). The main issue here is that ResBlock isn't returning the correct number of vector features that need to be used to compute the pose.

y_pose = y_pose[:, :, [2, 0, 1]]

Here y_pose needs to be a 3D vector, but resblocks return multidimensional vectors.

For now the fix is to not use ResBlock and set num_res_units to 0.

Also added a weighted mse loss to try to focus the SDF models on the zero level set region.

def forward(self, input: Tensor, target: Tensor) -> Tensor:

Also includes some additional args to PC VAE

Fixes #<issue_number>

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@benjijamorris benjijamorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you remove the commented out code?

@ritvikvasan
Copy link
Member Author

will get to this soon

@ritvikvasan ritvikvasan closed this Jul 2, 2024
@ritvikvasan ritvikvasan deleted the bugfix/equiv_padding_weightedmse branch July 2, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants