Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a temporary fix to
vae/image_encoder
whereConvolution
class expects padding values to be tuple or int (cannot pass None). The main issue here is thatResBlock
isn't returning the correct number of vector features that need to be used to compute the pose.cyto-dl/cyto_dl/models/vae/image_encoder.py
Line 165 in dc30155
Here
y_pose
needs to be a 3D vector, but resblocks return multidimensional vectors.For now the fix is to not use
ResBlock
and setnum_res_units
to 0.Also added a weighted mse loss to try to focus the SDF models on the zero level set region.
cyto-dl/cyto_dl/nn/losses/weighted_mse_loss.py
Line 19 in dc30155
Also includes some additional args to PC VAE
Fixes #<issue_number>
Before submitting
pytest
command?pre-commit run -a
command?Did you have fun?
Make sure you had fun coding 🙃