Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add save config function #382

Merged
merged 2 commits into from
May 8, 2024
Merged

Add save config function #382

merged 2 commits into from
May 8, 2024

Conversation

saeliddp
Copy link
Contributor

@saeliddp saeliddp commented May 6, 2024

What does this PR do?

This PR addresses a few of the issues with cyto-dl/plugin integration that we uncovered on Friday.

  1. Require a new version of bioio
  2. Add a save_config function to the existing API so that we can save the config with the overrides, not just the default config

Testing

I tested these changes on a sandbox branch of the plugin, manually verifying that prediction could be started up with a config saved using save_config during training.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@benjijamorris benjijamorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet!

benjijamorris
benjijamorris previously approved these changes May 6, 2024
Copy link
Contributor

@yrkim98 yrkim98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@saeliddp saeliddp merged commit cac51a4 into main May 8, 2024
1 of 6 checks passed
@saeliddp saeliddp deleted the feature/manual_config_save branch May 8, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants