Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin/bump on main merge #390

Merged
merged 5 commits into from
Jun 28, 2024
Merged

Admin/bump on main merge #390

merged 5 commits into from
Jun 28, 2024

Conversation

benjijamorris
Copy link
Contributor

What does this PR do?

Trying this again to account for CytoDL's branch protections. This implements two workflows:

  1. bump
  • runs when a non-bump pr is merged into main
  • creates a pr called 'admin/version-bump'
  1. publish
  • runs when an admin/version-bump pr is merged into main. NOTE patch/major bumpversion prs will also have to match this naming convention
  • publishes to pypi

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

amilworks
amilworks approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@amilworks amilworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this should fix the bump issues!

@benjijamorris benjijamorris merged commit 8ec8e0f into main Jun 28, 2024
4 of 6 checks passed
@benjijamorris benjijamorris deleted the admin/bump_on_main_merge branch June 28, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amilworks amilworks amilworks approved these changes

@ritvikvasan ritvikvasan Awaiting requested review from ritvikvasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjijamorris @amilworks