Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin/version bump #394

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Admin/version bump #394

merged 5 commits into from
Jul 1, 2024

Conversation

benjijamorris
Copy link
Contributor

What does this PR do?

clean up publish workflow

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@amilworks amilworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! So just checking, you are removing the bump install from the workflow and building with pdm. Looks good to me!

@benjijamorris benjijamorris merged commit 3fecc1b into main Jul 1, 2024
4 of 6 checks passed
@benjijamorris benjijamorris deleted the admin/version-bump branch July 1, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants