use plugin configuration #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeliddp
reviewed
Jul 2, 2024
| - git tag --delete 1.0.0 2.0.0 2.1.0 2.1.1 2.1.2 2.1.2.dev0 2.1.2.dev1 | ||
| """ | ||
|
|
||
| import subprocess # nosec |
There was a problem hiding this comment.
bandit (part of our precommit) flags possible security vulnerabilities and it was mad about subprocess use, nosec skips that line
saeliddp
reviewed
Jul 2, 2024
| # -----DO NOT MODIFY THIS FILE----- | ||
| # This file should only be modified by bumpver, which should in turn only be ran | ||
| # via a GH Action | ||
| version = "0.1.7" |
There was a problem hiding this comment.
I think in order to complete this setup, you need to have something like this which watches for modifications to version.toml then builds and publishes if version.toml has been modified. You could also build and publish manually if you prefer
There was a problem hiding this comment.
Note that ours is currently set up to publish to artifactory, so yours might look more like this
There was a problem hiding this comment.
ah good point, I'll modify our publish.yml
hughes036
previously approved these changes
Jul 2, 2024
benjijamorris
commented
Jul 2, 2024
saeliddp
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Incorporate plugin's bump workflow
Before submitting
pytestcommand?pre-commit run -acommand?Did you have fun?
Make sure you had fun coding 🙃