-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ViT Speedup #399
ViT Speedup #399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! some minor comments but ignore if not useful
cyto_dl/nn/vits/blocks/patchify.py
Outdated
*[ | ||
Rearrange( | ||
"(n_patch_y n_patch_x) b c -> b c n_patch_y n_patch_x", | ||
n_patch_y=n_patches[1], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is n_patches here?
cyto_dl/nn/vits/blocks/patchify.py
Outdated
Reduce( | ||
"b c n_patch_y n_patch_x -> b c (n_patch_y patch_size_y) (n_patch_x patch_size_x)", | ||
reduction="repeat", | ||
patch_size_y=patch_size[1], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is patch_size[1]?
cyto_dl/nn/vits/cross_mae.py
Outdated
@@ -90,18 +90,28 @@ def init_weight(self): | |||
|
|||
def forward(self, features, forward_indexes, backward_indexes): | |||
# HACK TODO allow usage of multiple intermediate feature weights, this works when decoder is 0 layers | |||
features = features.squeeze(0) | |||
features = features[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is features[0]?
What does this PR do?
Before submitting
pytest
command?pre-commit run -a
command?Did you have fun?
Make sure you had fun coding 🙃