Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add strict=false loading to eval #414

Merged
merged 2 commits into from
Aug 14, 2024
Merged

add strict=false loading to eval #414

merged 2 commits into from
Aug 14, 2024

Conversation

benjijamorris
Copy link
Contributor

What does this PR do?

  • consolidate loading utils to new file
  • check for strict=false and weights_only during eval

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@benjijamorris benjijamorris requested a review from yrkim98 August 12, 2024 17:45
@benjijamorris benjijamorris merged commit fd4d67a into main Aug 14, 2024
4 of 6 checks passed
@benjijamorris benjijamorris deleted the bugfix/strict_load_eval branch August 14, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrkim98 yrkim98 yrkim98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjijamorris @yrkim98