upgrade tifffile #436
Merged
upgrade tifffile #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job figuring this out! Tentatively seems good, based on the logs of the Test job, but let's merge the result of this action into this feature branch before going ahead, to confirm the bug is fully resolved. |
…ate_2024-10-08_20-42 admin/requirements-update_2024-10-08_20-42
* update precommit * style changes with updated precommit * bandit skips * precommit * fix file checking * check if prior is str --------- Co-authored-by: Benjamin Morris <[email protected]>
ritvikvasan
approved these changes
Oct 11, 2024
| @@ -2,23 +2,23 @@ | |||
| # Please do not edit it manually. | |||
|
|
|||
| aicscytoparam==0.1.12 | |||
| aicsimageio==4.14.0 | |||
| aicsimageio==4.11.0 | |||
There was a problem hiding this comment.
tifffile was upgraded but aicsimageio was downgraded? Also do we install both bioio and aicsimageio?
There was a problem hiding this comment.
cyto-dl just uses bioio, aicsimageio is a dependency of pyshtools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previous tests were failing because the tifffile version in the test-requirements was too old. Regular installation worked, but for the sake of passing tests, this enforces the tifffile version.
Before submitting
pytestcommand?pre-commit run -acommand?Did you have fun?
Make sure you had fun coding 🙃