Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to strict=True for plugin config, add overlap #443

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Default to strict=True for plugin config, add overlap #443

merged 2 commits into from
Nov 12, 2024

Conversation

yrkim98
Copy link
Contributor

@yrkim98 yrkim98 commented Nov 11, 2024

What does this PR do?

  • Changes the default segmentation_plugin config to use strict=True, weights_only=False by default.
  • Adding a .2 overlap, as discussed with @smishra3

amilworks
amilworks approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@amilworks amilworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

20 percent overlap seems good, interested to see results run on that same data to verify that the blockiness is gone.

@yrkim98 yrkim98 merged commit ab630c9 into main Nov 12, 2024
4 of 6 checks passed
@yrkim98 yrkim98 deleted the plugin_config_fixes branch November 12, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjijamorris benjijamorris benjijamorris approved these changes

@amilworks amilworks amilworks approved these changes

@hughes036 hughes036 hughes036 approved these changes

@smishra3 smishra3 Awaiting requested review from smishra3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yrkim98 @hughes036 @amilworks @benjijamorris