Added the option for image to take its original size

[MisustinIvan]

you can now do .Size(0,0) and the image takes its original size

[MisustinIvan]

Because i am not if there is a way to do this without this change if you use image from URL. You can of course just write your own function that fetches the image and gets the size, but whats the point of ImageWithURLWidget? I was also thinking about adding a option to set a size constraint and just scale the image while keeping the aspect ratio to fit the constraint. It would be nice if you shared some feedback, thanks!

[MisustinIvan]

I have also thought about replacing the behavior when passing in (-1, -1) to Size with this, because the current one kinda sucks and just stretches the Image.

[gucio321]

Hi! Thank you for your PR.
I think this is very good idea and I'm wondering why it isn't there already 😁

Just a few things:

[MisustinIvan]

Made it default behavior, ran the CI on my fork, everything seems fine to me. You can test the new behavior using the provided code snippet (you have to download the image):

func loop() {
	g.SingleWindow().Layout(
		g.Style().SetFontSize(20).To(
			g.Label("Default behavior:"),
		),
		g.Label("Image with URL:"),
		g.ImageWithURL("https://go.dev/blog/gopher/header.jpg"),
		g.Label("Image with file:"),
		g.ImageWithFile("./header.png"),

		g.Dummy(0, 100),

		g.Style().SetFontSize(20).To(
			g.Label("Custom size:"),
		),
		g.Label("Image with URL:"),
		g.ImageWithURL("https://go.dev/blog/gopher/header.jpg").Size(200, 200),
		g.Label("Image with file:"),
		g.ImageWithFile("./header.png").Size(200, 200),
	)
}

func main() {
	wnd := g.NewMasterWindow("New img behavior test", 1000, 1000, 0)
	wnd.Run(loop)
}

[MisustinIvan]

And would you be able to recommend me some things to work on in this project? I find it quite cool and would like to contribute some more. 😄

[gucio321]

2 more things:

• could you wite a comment over ImageWidget (and probably ImageWithURL and other Image*type definition and describe what0` does
• there is still one liner issue

[gucio321]

@MisustinIvan generally, we have 3 types of issues:

1. giu-related stuff - e.g. missing functions, some nice enhancements for API (or things like this PR). I've tagged them with good first issue Good for newcomers
2. issues with cimgui-go (which are the worst sh*t I've ever seen 😄). In general they are caused by our migration from imgui-go to cimgui-go and the fact that cimgui-go was/is early in development. It works but it requires some fixes.
3. well, we have one more type of issue: since migration in cimgui-go Migration #628 I was forced to disable some widgets (e.g. CodeEditor, MarkdownEditor end so on). Now it'd be nice to re-enable them but it requires work on cimgui-go and even writing some C wrapers for C++ projects in lua (basing on https://github.com/cimgui like I did e.g. for markdown in https://github.com/gucio321/cimmarkdown)

[MisustinIvan]

Added the comments and fixed linter complaint, everything should be fine.

[MisustinIvan]

Bruh does the linter really want comments to end with period...

[MisustinIvan]

Check passed, everything seems fine to me!

[gucio321]

nice, thank you

[gucio321]

Bruh does the linter really want comments to end with period...

you can use golangci-lint run --fix ./... and this should automatically fix that.

[MisustinIvan]

thanks, will try that next time!

[MisustinIvan]

btw what is the best practice, github is asking me if I want to delete the feature branch. Should i delete it or keep it?

[gucio321]

I thing you should delete. these commits are in master anyway and if you keep every branch, you'll have hundreds of them some day 😄