Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cimgui go to v1.1.0 #895

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Conversation

gucio321
Copy link
Collaborator

@gucio321 gucio321 commented Oct 29, 2024

This Pull Request updates cimgui-go to v1.1.0 manually (as some annoying guy - I don't know him at all - did breaking changes since last release).

I attach release notes - just in case:

cimgui-go v1.1.0 Release Notes

Introduction

Hi!
We present another release of cimgui-go today.
Its major highlights are:

  • implementation of the ImGuizmo extension
  • Imgui update
  • bugfix in glfwbackend causing GL error in some circumstances.
  • fix of crucial issues in the internal conversions mechanism
  • package layout redesign (BREAKING CHANGE)
  • change of type for all in/out slices to pointers (BREAKING CHANGE)
  • improvement of Vector type - it now shares the Slice() method.

Breaking Changes

  • if you use a slice as an argument to cimgui-go function, replace it with utils.SliceToPtr(yourslice)
    • this was necessary, because we cannot in fact determine whether a C pointer is a Slice or Pointer. Conversion from slice to pointer is easier and makes more sense than conversion from ptr to slice.
    • There was an issue making it impossible to pass an empty slice or nil (runtime panic)
  • ConvertCTypes and some Wrap* functions have been hidden.
    • you shouldn't have to use these functions - its use should be handled internally by cimgui-go. They are highly unsafe.
  • imgui.Vector was moved to vectors.Vector
    • Vector type does not belong to the imgui package so putting it there isn't the right approach.
  • imgui.SliceToPtr was moved to utils.SliceToPtr
    • As above: this function does not belong to imgui's code and should not be there.
  • datautils package was renamed to utils.
    • Does it make it work better? - No, but this name is shorter. This package was entirely redesigned anyway so a name change will not break much more.

We are so sorry for these breaking changes. We hope their positive impact on your project will be much greater than your dissatisfaction related to implementing them. We promise we'll try to avoid them in future releases so that you can update smoothly.

What's Changed

Full Changelog: AllenDang/cimgui-go@v1.0.3...v1.1.0

superseeds and closes #896

@gucio321 gucio321 merged commit 4fb044d into AllenDang:master Oct 29, 2024
4 checks passed
@gucio321 gucio321 deleted the upgrade-cimgui-go branch October 29, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant