-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SweepFormula/psxKernel: Various fixes #2023
base: main
Are you sure you want to change the base?
Commits on Nov 18, 2024
-
SweepFormula/psxKernel: Skip kernel creation for too large decayTau
Requested change by Tim Jarsky.
Configuration menu - View commit details
-
Copy full SHA for db10675 - Browse repository at this point
Copy the full SHA db10675View commit details -
SF_OperationEpochsImpl: Fix giving up too early
We want to continue the loop even if one single select dataset did not had any epoch info. Bug introduced in 595daef (MIES_SweepFormula_PSX.ipf: Add support for multiple ranges, 2024-02-02).
Configuration menu - View commit details
-
Copy full SHA for e8518a5 - Browse repository at this point
Copy the full SHA e8518a5View commit details -
PSX_OperationKernel: Avoid assertion with invalid ranges
We need to zap all null waves before storing the wave ref wave in the JSON wavenote. The order does matter but SFH_GetSweepsForFormula also ignores null ranges so we end up being ordered again in the end. Bug introduced in 595daef (MIES_SweepFormula_PSX.ipf: Add support for multiple ranges, 2024-02-02).
Configuration menu - View commit details
-
Copy full SHA for 142cbcd - Browse repository at this point
Copy the full SHA 142cbcdView commit details -
SFH_ExtendIncompleteRanges: Ignore null ranges
The additional /Z in the range based for loop is not required, but that is a bug reported to WM. Forgotten in 422eac8 (SF: Adapt SFH_EvaluateRange for multi dataset input, 2024-01-20).
Configuration menu - View commit details
-
Copy full SHA for 731887b - Browse repository at this point
Copy the full SHA 731887bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c160389 - Browse repository at this point
Copy the full SHA c160389View commit details -
PSX_Operation: Handle partial results better
We are now removing empty entries in the output wave. This avoids an issue with psxPrep which did not anticipate that. As we are now not feeding in any null waves into PSX_OperationImpl we can also remove the checks there.
Configuration menu - View commit details
-
Copy full SHA for 24afbdd - Browse repository at this point
Copy the full SHA 24afbddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9531183 - Browse repository at this point
Copy the full SHA 9531183View commit details -
PSX_OperationStatsImpl: Rework range handling
The current implementation for the ranges did not handle multiple passed epochs nor epoch wildcards. The check for intersecting ranges added in 6d10790 (PSX_OperationStatsImpl: Assert on intersecting ranges, 2024-02-06) was also broken. While thinking about the current approach it was recognized that we actually want to collect the event data from all sweep ranges of all sweeps from the same equivalence class. This has now been done. We also support list of epochs and epoch wildcards.
Configuration menu - View commit details
-
Copy full SHA for 54d37e8 - Browse repository at this point
Copy the full SHA 54d37e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bee6a9 - Browse repository at this point
Copy the full SHA 5bee6a9View commit details -
PSX_OperationImpl: Reorganize code for no event case
This prepares for a future commit where we throw away single events and thus PSX_AnalyzePeaks can result in no events event if we found peaks in PSX_FindPeaks.
Configuration menu - View commit details
-
Copy full SHA for 5901856 - Browse repository at this point
Copy the full SHA 5901856View commit details -
PSX_AnalyzePeaks: Factor out calculation of various event properties
In a future commit we want to reuse these calculations for event filtering.
Configuration menu - View commit details
-
Copy full SHA for 7b150fc - Browse repository at this point
Copy the full SHA 7b150fcView commit details -
PSX_AnalyzePeaks: Skip superfluous redimension calls
We know how many entries in psxEvent and eventFit we have before starting the loop so we can just call Redimension before and are done.
Configuration menu - View commit details
-
Copy full SHA for 2eeb44f - Browse repository at this point
Copy the full SHA 2eeb44fView commit details -
PSX_AnalyzePeaks: Throw away events with different sign as the kernel…
… amplitude We need to filter that out first as we need the neighbouring distance to the passing events. And we also have to introduce an override setting as otherwise the tests don't pass.
Configuration menu - View commit details
-
Copy full SHA for b34fb6e - Browse repository at this point
Copy the full SHA b34fb6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 527868a - Browse repository at this point
Copy the full SHA 527868aView commit details -
PSX_GetSingleEventRange: Make the offset dependent on tau
We only use the fixed value in case tau is NaN.
Configuration menu - View commit details
-
Copy full SHA for 322383b - Browse repository at this point
Copy the full SHA 322383bView commit details -
PSX_UpdateSingleEventGraph: Check passed index
We can be called from PSX_PlotInteractionHook where we don't know if the passed index is valid. Let's do nothing if the index is out of range.
Configuration menu - View commit details
-
Copy full SHA for 023d0e0 - Browse repository at this point
Copy the full SHA 023d0e0View commit details -
SF_PreparePlotter: Remove controls/draw elements on existing panels
In dc9ed87 (SF_PreparePlotter: Don't kill and recreate the main panel for SF_DM_SUBWINDOWS, 2024-06-19) we switched from killing the sweepformula plot to clearing it. But we forgot to remove additional controls and draw elements added by e.g. PSX. And now we also have to explicitly remove TraceUserData (TUD) as these are not cleaned up automatically anymore, as killing an embedded subwindow does not trigger the main window hook.
Configuration menu - View commit details
-
Copy full SHA for 12f9b03 - Browse repository at this point
Copy the full SHA 12f9b03View commit details -
Configuration menu - View commit details
-
Copy full SHA for bce9ab2 - Browse repository at this point
Copy the full SHA bce9ab2View commit details -
PSX_ApplyMacroToExistingPanel: Fix execution
Due to the changed window handling in dc9ed87 (SF_PreparePlotter: Don't kill and recreate the main panel for SF_DM_SUBWINDOWS, 2024-06-19) we need to ensure that the host window of the SF panel is active.
Configuration menu - View commit details
-
Copy full SHA for d1920b5 - Browse repository at this point
Copy the full SHA d1920b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63a6a36 - Browse repository at this point
Copy the full SHA 63a6a36View commit details -
DeepCopyWaveRefWave: Allow src to contain null waves
This makes it easier to use and is more according to our philosopy that null wave refs should be preferred over empty waves.
Configuration menu - View commit details
-
Copy full SHA for ec4aa97 - Browse repository at this point
Copy the full SHA ec4aa97View commit details -
DeepCopyWaveRefWave: Nificy the code
We only need index in the else branch and some more spaces are nice.
Configuration menu - View commit details
-
Copy full SHA for 11783cd - Browse repository at this point
Copy the full SHA 11783cdView commit details -
PSX_OperationImpl: Always return a result
Using psxPrep requires sweep data from psx. But we used to only return sweep data if we have found events. We now always return sweep data so that psxPrep always works.
Configuration menu - View commit details
-
Copy full SHA for 2e41b47 - Browse repository at this point
Copy the full SHA 2e41b47View commit details -
PSX: Change order of offsetting and filtering
We now first offset and then filter. This requires that we also rename all variables, constants and dimension labels. Change requested by Tim Jarsky.
Configuration menu - View commit details
-
Copy full SHA for 5f6264c - Browse repository at this point
Copy the full SHA 5f6264cView commit details -
Configuration menu - View commit details
-
Copy full SHA for af76076 - Browse repository at this point
Copy the full SHA af76076View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26579be - Browse repository at this point
Copy the full SHA 26579beView commit details -
Configuration menu - View commit details
-
Copy full SHA for ba27685 - Browse repository at this point
Copy the full SHA ba27685View commit details
Commits on Nov 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c239c3d - Browse repository at this point
Copy the full SHA c239c3dView commit details
Commits on Nov 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4a6e006 - Browse repository at this point
Copy the full SHA 4a6e006View commit details