Skip to content

Commit

Permalink
tests: small fix to remove a confusing print statement / clean up code (
Browse files Browse the repository at this point in the history
#1203)

* tests: small fix to remove a confusing print statement and to clean up code

* tests: indents caused coverage failures
  • Loading branch information
dbirman authored Jan 3, 2025
1 parent 0dd4ed9 commit f67caaa
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions tests/test_quality_control.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def test_constructors(self):
stage=Stage.PROCESSING,
metrics=[
QCMetric(
name="Multiple values example",
name="Dict example",
value={"stuff": "in_a_dict"},
status_history=[
QCStatus(evaluator="Bob", timestamp=datetime.fromisoformat("2020-10-10"), status=Status.PASS)
Expand Down Expand Up @@ -56,7 +56,7 @@ def test_overall_status(self):
stage=Stage.PROCESSING,
metrics=[
QCMetric(
name="Multiple values example",
name="Dict example",
value={"stuff": "in_a_dict"},
status_history=[
QCStatus(evaluator="Bob", timestamp=datetime.fromisoformat("2020-10-10"), status=Status.PASS)
Expand Down Expand Up @@ -298,7 +298,7 @@ def test_multi_session(self):
stage=Stage.PROCESSING,
metrics=[
QCMetric(
name="Multiple values example",
name="Dict example",
value={"stuff": "in_a_dict"},
status_history=[
QCStatus(evaluator="Automated", timestamp=t0, status=Status.PASS),
Expand All @@ -318,7 +318,7 @@ def test_multi_session(self):
stage=Stage.PROCESSING,
metrics=[
QCMetric(
name="Multiple values example",
name="Dict with evaluated assets list",
value={"stuff": "in_a_dict"},
status_history=[
QCStatus(evaluator="Automated", timestamp=t0, status=Status.PASS),
Expand All @@ -328,7 +328,6 @@ def test_multi_session(self):
],
)

print(context.exception)
self.assertTrue(
"is in a single-asset QCEvaluation and should not have evaluated_assets" in repr(context.exception)
)
Expand All @@ -341,7 +340,7 @@ def test_multi_session(self):
stage=Stage.MULTI_ASSET,
metrics=[
QCMetric(
name="Multiple values example",
name="Missing evaluated assets",
value={"stuff": "in_a_dict"},
status_history=[
QCStatus(evaluator="Automated", timestamp=t0, status=Status.PASS),
Expand Down

0 comments on commit f67caaa

Please sign in to comment.