Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding a max file size warning #1201

Merged
merged 10 commits into from
Jan 3, 2025
Merged

feat: adding a max file size warning #1201

merged 10 commits into from
Jan 3, 2025

Conversation

dbirman
Copy link
Member

@dbirman dbirman commented Jan 2, 2025

This PR adds a call to logging.warning when the file size generated by write_standard_file exceeds 500 KB

@dbirman dbirman linked an issue Jan 2, 2025 that may be closed by this pull request
7 tasks
@dbirman dbirman requested a review from jtyoung84 January 2, 2025 22:53
Copy link
Collaborator

@jtyoung84 jtyoung84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve it as it satisfies the wording of the issue, but it'd be more helpful to have a method that estimates the expected file size from the json contents because we don't always write to files. We also wouldn't need to modify the test_examples.py file if we checked the size of the json object.

@dbirman
Copy link
Member Author

dbirman commented Jan 3, 2025

I'll approve it as it satisfies the wording of the issue, but it'd be more helpful to have a method that estimates the expected file size from the json contents because we don't always write to files. We also wouldn't need to modify the test_examples.py file if we checked the size of the json object.

Seems like we should just do that then?

@jtyoung84
Copy link
Collaborator

I'll approve it as it satisfies the wording of the issue, but it'd be more helpful to have a method that estimates the expected file size from the json contents because we don't always write to files. We also wouldn't need to modify the test_examples.py file if we checked the size of the json object.

Seems like we should just do that then?

Sounds good if you want to modify the branch. You can re-request a review from me if you want.

@dbirman dbirman added this pull request to the merge queue Jan 3, 2025
Merged via the queue into dev with commit 13a9c9a Jan 3, 2025
5 checks passed
@dbirman dbirman deleted the 1162-file-size-warnings branch January 3, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File size warnings
2 participants