-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding a max file size warning #1201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve it as it satisfies the wording of the issue, but it'd be more helpful to have a method that estimates the expected file size from the json contents because we don't always write to files. We also wouldn't need to modify the test_examples.py
file if we checked the size of the json object.
Seems like we should just do that then? |
Sounds good if you want to modify the branch. You can re-request a review from me if you want. |
This PR adds a call to
logging.warning
when the file size generated bywrite_standard_file
exceeds 500 KB