Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1086 bump aind flake8 extensions to 06 #1210

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

dbirman
Copy link
Member

@dbirman dbirman commented Jan 6, 2025

This PR upgrades aind-flake8-extensions to enforce the use of AwareDatetimeWithDefault. flake8 will now throw a warning if a user tries to define a field with datetime.

Errors look like:

src/aind_data_schema/core/rig.py:61:5: PF003 Field 'date2' should use 'AwareDatetimeWithDefault' instead of datetime

@dbirman dbirman linked an issue Jan 6, 2025 that may be closed by this pull request
7 tasks
@dbirman dbirman requested a review from saskiad January 6, 2025 22:11
@dbirman
Copy link
Member Author

dbirman commented Jan 7, 2025

(waiting to merge until 1.3 is merged back into dev to prevent conflicts)

@dbirman dbirman added this pull request to the merge queue Jan 7, 2025
Merged via the queue into dev with commit 1e5454e Jan 7, 2025
5 checks passed
@dbirman dbirman deleted the 1086-bump-aind-flake8-extensions-to-06 branch January 7, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump aind-flake8-extensions to 0.6
2 participants