-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4343 allow custom notification images #4344
Merged
EricClaeys
merged 38 commits into
v2024.12.06_02
from
4343-allow-custom-notification-images
Feb 16, 2025
Merged
4343 allow custom notification images #4344
EricClaeys
merged 38 commits into
v2024.12.06_02
from
4343-allow-custom-notification-images
Feb 16, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agesCameraOffDuringNight.png
…gesConfigurationNeeded.jpg
…gesConfigurationNeeded.png
…tionImages.sh Use E_()
Also, change logic so we exit earlier and the un-indent code after that
Also, exit with non-hard-coded numbers
Also, use E_() and W_()
Also, use E_() and W_()
This required moving ALLSKY_MYFILES_* higher in the file
Also, use E_() and W_()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #4343