Added symlink support on removeCommonPath #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatyas
added a commit
to mmatyas/EmulationStation
that referenced
this pull request
Aug 2, 2016
The problem is that removeCommonPath doesn't work with symlinks 'cause fs::canonical returns the path of the original file instead of the symlink's, and relativeTo doesn't necessarily have to match the former, it's ment to match the latter. This causes that the scraped metadata doesn't work. We can avoid this by applying fs::canonical just to the parent path and then append the filename when the file is a symlink. Source: Aloshi#430
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I like to have my ROMs in one separate path and use symlinks in the roms folders so I can use the same ROMs in multiple emulators without having to copy them. The problem is that removeCommonPath doesn't work with symlinks 'cause fs::canonical returns the path of the original file instead of the symlink's, and relativeTo doesn't necessarily have to match the former, it's ment to match the latter. This causes that the scraped metadata doesn't work.
We can avoid this by applying fs::canonical just to the parent path and then append the filename when the file is a symlink. I've tested it on a Raspberry PI running RetroPie but it's all done with boost so it should work on Windows too.