Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for macOS #18

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fixes for macOS #18

wants to merge 8 commits into from

Conversation

barracuda156
Copy link

This PR:

  1. Adds initial support for PPC.
  2. Fixes the build on macOS.
  3. Makes minor fixes to makefiles: there is some inconsistency with targets, like non-existent folders being added etc.

What still needs to be done:

  1. Implement tests for PPC specifically or platform-independent (there is no plain folder in tests now).
  2. Fix dylib target for macOS: current target uses Linux-only linker flags.
  3. What is the status of tool target? Is it broken, WIP or why is it disabled (and incomplete)?

@barracuda156
Copy link
Author

@NCIC-AlphaSparse @xupinjie @JacoCheung Could someone look into this, please? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NCIC-AlphaSparse NCIC-AlphaSparse Awaiting requested review from NCIC-AlphaSparse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@barracuda156