Misplaced swamp portal

[szapp]

There's a portal in the swamp that renders the water invisible at some point.

[AmProsius]

This issue was fixed in freddy's world patch.

[szapp]

Are there details of this issue available? Like screenshots and especially the name of the portal (rooms)?

[AmProsius]

You can clearly see the issue at OW_PATH_BLOODFLY12_SPAWN01. There's a chunk of swamp missing.

[szapp]

This fix will require a bit of studying: Is the only solution to remove the portal all together? Or can the portal be adjusted?

If removed, it has to be recreated and added to the world and portal list on every save.

[szapp]

Name of the portals(!) is P:PSU01_.

[szapp]

My thought now is whether the portal cannot be changed at run-time but only while the world BSP tree is created. That would mean, hooking the constructors to prevent creating the portals to the sector "PSU01" (or the sector itself?). That would require some assembly code hooking (for performance) and might turn this fix into a session fix.

[szapp]

Let’s check if the (formerly called?) Union primary patch (part of a basic Union installation) doesn’t already fix this problem. I read something about this several times.

[szapp]

This is the relevant portion of the Union.patch file (lines 1428-1432). I haven't yet looked up what exactly is being done there. Nevertheless, it does not seem to fix this issue here. Maybe it addresses another issue.

    #patch [Disable portal in the swamp]
        HEX @0x00521086 = 'E9 B5 87 21 00'
        HEX @0x0051C9B6 = 'E9 B4 CE 21 00'
        HEX @0x00739836 = '8D 4C 24 78 51 E9 4B 78 DE FF 8B 4D 08 81 39 50 53 55 30 75 EB 8D 4C 24 78 51 C7 44 E4 34 45 3E 10 4E C7 44 E4 28 85 D8 0C 4E E9 36 78 DE FF 8D 4C 24 5C 51 E9 4C 31 DE FF 8B 4E 18 8B 49 18 81 79 04 53 55 30 31 75 E7 81 39 50 3A 5F 50 75 DF 8D 4C 24 5C 51 C7 44 E4 2C 45 3E 10 4E C7 44 E4 24 85 D8 0C 4E E9 2B 31 DE FF'
    #/patch

[AmProsius]

I've seen something like that in the changelog, but also realized that it didn't fix the issue.