feat: otter sdk training - model extension #2411
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1d862e2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
github-actions
bot
added
enhancement
sdo-1A
force-pushed
the
feat/training-sdk-model-extension
branch
from
79fbfac
to
5ab818f
Compare
fpaul-1A
previously approved these changes
Nov 6, 2024
cpaulve-1A
reviewed
Nov 6, 2024
...owcase/src/assets/trainings/sdk/steps/model-extension/exercise/core/flight/flight.reviver.ts
Outdated
Show resolved
Hide resolved
cpaulve-1A
reviewed
Nov 6, 2024
apps/showcase/src/assets/trainings/sdk/steps/model-extension/instructions.html
Outdated
Show resolved
Hide resolved
cpaulve-1A
reviewed
Nov 6, 2024
...owcase/src/assets/trainings/sdk/steps/model-extension/solution/core/flight/flight.reviver.ts
Show resolved
Hide resolved
fpaul-1A
force-pushed
the
feat/training-sdk-model-extension
branch
from
5ab818f
to
f929022
Compare
sdo-1A
commented
Nov 18, 2024
apps/showcase/src/assets/trainings/sdk/steps/model-extension/instructions.html
Outdated
Show resolved
Hide resolved
apps/showcase/src/assets/trainings/sdk/steps/model-extension/exercise/core/flight/flight.ts
Show resolved
Hide resolved
apps/showcase/src/assets/trainings/sdk/steps/model-extension/instructions.md
Outdated
Show resolved
Hide resolved
apps/showcase/src/assets/trainings/sdk/steps/model-extension/instructions.md
Outdated
Show resolved
Hide resolved
apps/showcase/src/assets/trainings/sdk/steps/model-extension/instructions.md
Outdated
Show resolved
Hide resolved
apps/showcase/src/assets/trainings/sdk/steps/model-extension/instructions.md
Outdated
Show resolved
Hide resolved
apps/showcase/src/assets/trainings/sdk/steps/model-extension/instructions.md
Show resolved
Hide resolved
fpaul-1A
force-pushed
the
feat/training-sdk-model-extension
branch
from
f929022
to
dabeb92
Compare
fpaul-1A
reviewed
Nov 18, 2024
apps/showcase/src/assets/trainings/sdk/shared/monorepo-template.json
Outdated
Show resolved
Hide resolved
kpanot
reviewed
Nov 18, 2024
fpaul-1A
force-pushed
the
feat/training-sdk-model-extension
branch
2 times, most recently
from
2645a1a
to
558242b
Compare
sdo-1A
commented
Nov 19, 2024
apps/showcase/src/assets/trainings/sdk/steps/model-extension/instructions.md
Outdated
Show resolved
Hide resolved
fpaul-1A
force-pushed
the
feat/training-sdk-model-extension
branch
from
558242b
to
8dafb89
Compare
cpaulve-1A
reviewed
Nov 20, 2024
apps/showcase/src/assets/trainings/sdk/steps/model-extension/exercise/core/flight/flight.ts
Show resolved
Hide resolved
cpaulve-1A
reviewed
Nov 20, 2024
| @@ -0,0 +1,36 @@ | |||
| { | |||
| "$schema": "../../../../../schemas/webcontainer-file-system-tree.schema.json", | |||
| "fileSystemTree": { | |||
There was a problem hiding this comment.
This is rather specific, this will not be shared with all the exercises. It should probably be generated from the exercise folder.
There was a problem hiding this comment.
I actually thought it could be used on other exercises, it's not specific to model extension, it's just an app calling the dummy api with mocks
There was a problem hiding this comment.
Should we have it versioned then in a similar fashion as the sdk? It will be easier to update the content and the dependencies
There was a problem hiding this comment.
it would be better to be versioned as files instead of JSON yes, as for monorepo-template.json
this can be done in a separate PR for both
fpaul-1A
force-pushed
the
feat/training-sdk-model-extension
branch
from
8dafb89
to
1d862e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
https://fpaul-1a.github.io/otter/#/sdk-training#8
Otter SDK Training - Model extension
NOTE: the exercise and solution files are combined with the existing training-sdk
Related issues
- No issue associated -