feat: otter sdk training - how to use the otter sdk #2493
Conversation
sdo-1A
force-pushed
the
feat/training-sdk-how-to-use
branch
from
07f2aaf
to
fa63274
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f6b4b49. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
github-actions
bot
added
enhancement
apps/showcase/src/assets/trainings/sdk/steps/typescript-sdk/exercise/app.component.ts
Outdated
Show resolved
Hide resolved
apps/showcase/src/assets/trainings/sdk/steps/typescript-sdk/solution/app.component.ts
Outdated
Show resolved
Hide resolved
| const localStorageStates: Record<string, Serializer<any>>[] = [/* Store to register in local storage */]; | ||
| const storageSync = new StorageSync({ | ||
| keys: localStorageStates, rehydrate: true | ||
| }); | ||
|
|
||
| const rootReducers = {}; | ||
|
|
||
| const metaReducers = [storageSync.localStorageSync()]; | ||
| const runtimeChecks: Partial<RuntimeChecks> = { | ||
| strictActionImmutability: false, | ||
| strictActionSerializability: false, | ||
| strictActionTypeUniqueness: !environment.production, | ||
| strictActionWithinNgZone: !environment.production, | ||
| strictStateImmutability: !environment.production, | ||
| strictStateSerializability: false | ||
| }; |
There was a problem hiding this comment.
we should remove all the @ngrx stuff, it's adding a lot of noise and is not the relevant for the sdk training
There was a problem hiding this comment.
I cleaned up the app.config.ts file, but I left the @ngrx dependencies in the package.json files since some are peer dependencies for other packages. What do you think?
There was a problem hiding this comment.
we are already installing using --legacy-peer-deps so I don't think the warnings will matter
there is no reason for @ngrx to be used in the training so we can safely remove the dependency
apps/showcase/src/assets/trainings/sdk/steps/typescript-sdk/exercise/app.component.ts
Outdated
Show resolved
Hide resolved
apps/showcase/src/assets/trainings/sdk/steps/typescript-sdk/solution/app.component.ts
Outdated
Show resolved
Hide resolved
apps/showcase/src/assets/trainings/sdk/steps/typescript-sdk/instructions.md
Outdated
Show resolved
Hide resolved
sdo-1A
force-pushed
the
feat/training-sdk-how-to-use
branch
from
fa63274
to
97cfa4c
Compare
apps/showcase/src/assets/trainings/sdk/steps/typescript-sdk/exercise/app.component.html
Outdated
Show resolved
Hide resolved
apps/showcase/src/assets/trainings/sdk/steps/typescript-sdk/exercise/app.component.html
Outdated
Show resolved
Hide resolved
apps/showcase/src/assets/trainings/sdk/steps/typescript-sdk/solution/app.config.ts
Outdated
Show resolved
Hide resolved
apps/showcase/src/assets/trainings/sdk/steps/typescript-sdk/exercise/app.component.ts
Outdated
Show resolved
Hide resolved
sdo-1A
force-pushed
the
feat/training-sdk-how-to-use
branch
from
97cfa4c
to
b46170a
Compare
sdo-1A
force-pushed
the
feat/training-sdk-how-to-use
branch
from
b46170a
to
d544e8d
Compare
sdo-1A
force-pushed
the
feat/training-sdk-how-to-use
branch
from
d544e8d
to
95a2a2d
Compare
sdo-1A
force-pushed
the
feat/training-sdk-how-to-use
branch
2 times, most recently
from
886642d
to
42b6554
Compare
sdo-1A
force-pushed
the
feat/training-sdk-how-to-use
branch
from
42b6554
to
f6b4b49
Compare
apps/showcase/src/assets/trainings/sdk/steps/typescript-sdk/exercise/app.component.ts
Show resolved
Hide resolved
apps/showcase/src/assets/trainings/sdk/steps/typescript-sdk/solution/app.component.ts
Show resolved
Hide resolved
| /** Title of the application */ | ||
| public title = 'tutorial-app'; | ||
|
|
There was a problem hiding this comment.
| /** Title of the application */ | |
| public title = 'tutorial-app'; |
There was a problem hiding this comment.
The title variable is currently being used in the test file app.component.spec.ts, we can update this test file eventually or remove them for the case of this training (but in a separate PR)
There was a problem hiding this comment.
we are not running the test and if we are it will fail :)
but yes we can do it in another PR
| /** Title of the application */ | ||
| public title = 'tutorial-app'; | ||
|
|
There was a problem hiding this comment.
| /** Title of the application */ | |
| public title = 'tutorial-app'; |
Proposed change
How to use the Otter SDK step
The goal is for the user to create a fetch client and use the pet API to display the results in the UI
Related issues
- No issue associated -